-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct 2 small bugs #5
base: master
Are you sure you want to change the base?
Conversation
change the behavior in case of parser error to disconnectFromHost and provide an empty response to the client Note: We could send a 400 BadRequest instead
Correct a bug that was still displaying error message and aborting in case of certificate error
Hi @BertrandThelen, Thank you for your contribution. |
Hi @msvetkin Finally managed to get everything set up correctly for gerrit. So the pull request has been sent there. |
update version
<< error << error.certificate(); | ||
if (error.error() == expectedError.error() || | ||
error.certificate() == expectedError.certificate()) { | ||
expected = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I happened to come across this pull request, and I wondered if the or
in the logic should be changed into an and
, since we're inverting the logic in the original code. Both there error type and the associated error certificate in the expected should match the actual error.
|
Returning a 400 Bad Request could be good but I do not know the full implication that this change could have to the code flow.