Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug ethernet 100BASE-TX auto-negotation issues by adding new
ESP_LOGD(...)
for register dumps.Tweak the
autonego_timeout_ms
vscheck_link_period_ms
to avoid unnecessary 4s hang on boot atesp_eth_start()
, bring up the eth netif later once the link is up.Small optimizations to
lan87xx_reset()
,lan87xx_negotiate()
,lan87xx_pwrctl()
to avoid 10ms/100ms waits.Change
lan87xx_negotiate()
to not unnecessarily restart auto-negotation when it is already enabled, and started after reset:Add new
ETH_CMD_G_ERROR_COUNTER
ioctl and log this on eth connect/disconnect events.