Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default implementation of drag-scroll #24425

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

eynsai
Copy link

@eynsai eynsai commented Sep 22, 2024

Description

This PR adds a default implementation of drag-scroll to QMK. High-resolution drag-scroll can potentially be much more complicated than conventional drag-scroll, making a default implementation useful. This PR cannot be merged independently. It strictly depends on PR 24422 being merged. Additionally, it depends on PR 24423 and PR 24424 - to the best of my knowledge it'll work without 24423 and 24424, but the value proposition of this PR will be substantially reduced without them.

Code is feature-complete, documentation is WIP.

Key features include:

  • Automatic scaling based on whether high resolution scrolling is on or not
  • Rate throttling (independently of the throttling applied to all pointing device tasks)
  • Sliding-window smoothing
  • Rounding error accumulation
  • X/Y axis snapping
  • Acceleration (velocity transfer curve)
  • Support for POINTING_DEVICE_COMBINED

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 22, 2024
@eynsai eynsai changed the base branch from master to develop September 22, 2024 06:21
@eynsai eynsai changed the title provide default implementation of dragscroll Default implementation of drag-scroll Sep 22, 2024
@eynsai eynsai marked this pull request as draft September 22, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant