-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolution for Not able to override step.provider.pkg property for data driven scenario #155
base: master
Are you sure you want to change the base?
Conversation
…e fileName is different.
Will add Unit Testcases soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjayswal please review this Pull request
Did you understand the issue? Please share the test case. I am afraid that solution will have impact on performance. |
Yes, DataDrivenScenario.java creates proxy steps and pass it to execute method of Scenario.java |
You can check by commenting step initialization to have lazy initialization in DD scenario |
I have tried that.
It takes proper step but breaks data passing to step as context does not get set properly,henxe data passed through files is not accessible using ${args[0]}.
On 28-Nov-2017 11:04 PM, cjayswal <[email protected]> wrote:
You can check by commenting step initialization<https://github.com/qmetry/qaf/blob/1e70f23256cd813880011934fc7aded9380b8346/src/com/qmetry/qaf/automation/step/client/DataDrivenScenario.java#L183> to have lazy initialization in DD scenario
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#155 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATpW8HW7I5IVbfL2bvAdHRQn4yn-P5REks5s7EQHgaJpZM4QtZBK>.
|
resolution for #154
we were using initStep only when step is not yet initiated.
we need to re init the step in case fileName is different as step.provider.pkg has changed