Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

chore: use pnpm and sn-gh-workflows v2 #232

Merged
merged 3 commits into from
Feb 13, 2024
Merged

chore: use pnpm and sn-gh-workflows v2 #232

merged 3 commits into from
Feb 13, 2024

Conversation

haxxmaxx
Copy link
Contributor

@haxxmaxx haxxmaxx commented Feb 2, 2024

No description provided.

@haxxmaxx haxxmaxx marked this pull request as ready for review February 2, 2024 08:22
@haxxmaxx haxxmaxx requested a review from a team as a code owner February 2, 2024 08:22
@haxxmaxx haxxmaxx requested review from enell and removed request for a team February 2, 2024 08:22
@haxxmaxx haxxmaxx mentioned this pull request Feb 2, 2024
Closed
1 task
@haxxmaxx haxxmaxx requested a review from a team February 2, 2024 14:28
@enell
Copy link

enell commented Feb 2, 2024

Did you use pnpm import to create the pnpm lock file?

@haxxmaxx
Copy link
Contributor Author

haxxmaxx commented Feb 2, 2024

Did you use pnpm import to create the pnpm lock file?

nope just install

niekvanstaveren
niekvanstaveren reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@niekvanstaveren niekvanstaveren left a comment •
edited by haxxmaxx
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of more things we probably need:

  • api specifications path
  • Secret for API key
  • Secret for NPM token

Changes look okay

@haxxmaxx haxxmaxx merged commit 1dcf856 into master Feb 13, 2024
4 checks passed
@haxxmaxx haxxmaxx deleted the crl/pnpm branch February 13, 2024 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niekvanstaveren niekvanstaveren niekvanstaveren left review comments

@enell enell enell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haxxmaxx @enell @niekvanstaveren