fix: use SVG renderer for labels

qlik-oss · Jan 12, 2024 · b0c9e2a · b0c9e2a
1 parent 4714491
commit b0c9e2a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/coloring/picasso/index.js b/src/coloring/picasso/index.js
@@ -153,11 +153,12 @@ export default function coloringFn(resources) {
      * @param {string} [cfg.styleReference='object.legend']
      * @returns {object}
      */
-    legend({ eventName, key, styleOptions } = {}) {
+    legend({ eventName, key, renderer, styleOptions } = {}) {
       return legend(
         {
           eventName,
           key,
+          renderer,
         },
         {
           legendConfig: chartColorModel.getLegendSettings(),

diff --git a/src/coloring/picasso/legend/visual.js b/src/coloring/picasso/legend/visual.js
@@ -12,7 +12,7 @@ export const legendShow = (legendProps, hc, coloring) => {
 };
 
 export function catLegend(componentConfig, opts) {
-  const { key } = componentConfig;
+  const { key, renderer } = componentConfig;
 
   const { scaleKey, scales, coloring, hc, constraints, styleOptions } = opts;
 
@@ -21,6 +21,7 @@ export function catLegend(componentConfig, opts) {
   return {
     type: "legend-cat",
     key: `${key}-cat`,
+    renderer,
     scale: s in scales ? s : scaleKey,
     show: legendShow(opts.legendConfig, hc, coloring),
     layout: {

diff --git a/src/pic-definition.js b/src/pic-definition.js
@@ -72,12 +72,15 @@ export default function picDefinition({
     };
   }
 
+  const textRenderer = getTextRenderer(flags);
+
   const colorDatum = picassoColoring.datumProps();
   const colorFill = picassoColoring.color();
 
   const leg = picassoColoring.legend({
     key: "color-legend",
     eventName: "ev",
+    renderer: textRenderer,
     styleOptions: {
       title: getLegendTitleStyle(theme, layout, flags),
       label: getLegendLabelStyle(theme, layout, flags),
@@ -86,7 +89,6 @@ export default function picDefinition({
   const axisLabelStyle = getAxisLabelStyle(theme, layout, flags);
   const valueLabelStyle = getValueLabelStyle(theme, layout, flags);
   const allowTooltip = !constraints.passive;
-  const textRenderer = getTextRenderer(flags);
 
   return {
     strategy: {