Adding support for h5py & fix memory pinning #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory pinning only works if the collate function returns Tensors or maps/iterables of Tensors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using h5py allows for faster building of the dataset.
I also noticed that your collate function first returned numpy arrays. However, memory pinning only works if the collate function returns Tensors or map/iterable of Tensors 1. I changed that and noticed faster training (I honestly cannot remember by how much it was faster).
Finally, I added the
prefetch_factorargument which was missing in theDataLoaders.Hope this will help.