-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence building #1026
Merged
Merged
Sequence building #1026
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4a3f739
feat: Add native creator alias
alecandido 2f8da08
feat: Add sequences concatenation alias
alecandido ba9584c
test: Test concatenation aliases
alecandido 9c31c8c
test: Test native creation alias
alecandido 6126c34
test: Test full sequence construction proposal
alecandido 9cd2076
fix: Accept sequence concatenation with more general iterables
alecandido 0861bae
fix: Extend type hints even for concatenation aliases
alecandido 7440502
fix: Pass all involved channels during synchronization
alecandido 47da122
feat: implement sequence.juxtapose
stavros11 18ec55d
fix: Remove deepcopies in sequence building
alecandido File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
from qibolab import create_platform | ||
from qibolab.execution_parameters import ExecutionParameters | ||
from qibolab.pulses import Delay | ||
|
||
|
||
def test_sequence_creation(): | ||
platform = create_platform("dummy") | ||
|
||
single = platform.natives.single_qubit | ||
two = platform.natives.two_qubit | ||
|
||
# How a complex sequence is supposed to be constructed | ||
# ---------------------------------------------------- | ||
|
||
p02 = two[(0, 2)] | ||
p12 = two[(1, 2)] | ||
q0 = single[0] | ||
q1 = single[1] | ||
q2 = single[2] | ||
ch1 = platform.qubits[1] | ||
|
||
seq = ( | ||
q1.RX() | ||
| p12.CZ() | ||
| [(ch1.drive, Delay(duration=6.5))] | ||
| q2.RX() | ||
| q0.RX12() | ||
| p02.CZ() | ||
) | ||
for q in range(3): | ||
seq |= single[q].MZ() | ||
|
||
# ---------------------------------------------------- | ||
|
||
nshots = 17 | ||
res = platform.execute([seq], ExecutionParameters(nshots=nshots)) | ||
|
||
for r in res.values(): | ||
assert r.shape == (nshots,) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we accept any iterable here? Isn't
PulseSequence
sufficient? Same for__or__
and__ior__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qibolab/tests/integration/test_sequence.py
Lines 22 to 29 in 746fe8f
The explicit pulse-like here (the
Delay
) is contained in alist
, which is perfectly homogeneous to aPulseSequence
(sincePulseSequence
is alist
subclass), but it's not aPulseSequence
.In general, it is very cheap to support, and quite user-friendly (e.g. even an iterator over
_Element
would work, so you can use literals such as list comprehension and generators, that otherwise should be manually wrapped in aPulseSequence
).