Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeprecationWarning for numpy > 1.25 #1395

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix DeprecationWarning for numpy > 1.25 #1395

merged 3 commits into from
Jul 24, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jul 19, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello self-assigned this Jul 19, 2024
@renatomello renatomello added this to the Qibo 0.2.10 milestone Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (c598c67) to head (e085386).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          78       78           
  Lines       11191    11192    +1     
=======================================
+ Hits        11190    11191    +1     
  Misses          1        1           
Flag Coverage Δ
unittests 99.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido alecandido changed the title Fix DeprecationWarning for numpy > 1.125 Fix DeprecationWarning for numpy > 1.25 Jul 19, 2024
@alecandido
Copy link
Member

At some point, we should also take into account migrating to NumPy 2.0, now that is out.

A much relevant improvement (to us) could be the following:
https://numpy.org/doc/stable/release/2.0.0-notes.html#array-api-compatible-functions-aliases
https://numpy.org/doc/stable/release/2.0.0-notes.html#array-api-compatible-functions-for-numpy-linalg
https://numpy.org/doc/stable/release/2.0.0-notes.html#array-api-standard-support-in-the-main-namespace

It was already documented for v1, and there are compatibility packages available
https://numpy.org/doc/stable/reference/array_api.html
but now it is available by default, and it should improve the compatibility with the other array frameworks (i.e. TensorFlow, PyTorch, JAX, CuPy, ...), since the Python API has been standardized (not all of them adopted it already, but they might do it).

@scarrazza scarrazza merged commit d8cc501 into master Jul 24, 2024
27 checks passed
@renatomello renatomello deleted the deprecation branch July 25, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants