Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix math erros in models.dbi.double_bracket docstrings #1394

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jul 17, 2024

Closes #1388. However, there are several methods in those classes that have no description of their args in their respective dosctrings. Someone with more knowledge of the classes should fix that too.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added this to the Qibo 0.2.10 milestone Jul 17, 2024
@renatomello renatomello self-assigned this Jul 17, 2024
@renatomello renatomello added dependencies Pull requests that update a dependency file bug Something isn't working labels Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (d8cc501) to head (560c4de).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          78       78           
  Lines       11192    11192           
=======================================
  Hits        11191    11191           
  Misses          1        1           
Flag Coverage Δ
unittests 99.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/qibo/models/dbi/double_bracket.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@MatteoRobbiati MatteoRobbiati added this pull request to the merge queue Jul 30, 2024
Merged via the queue into master with commit 26aa661 Jul 30, 2024
27 checks passed
@scarrazza scarrazza deleted the docs branch August 3, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Math input error in docs
3 participants