Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce circuit kwargs to QFT class #1393

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Introduce circuit kwargs to QFT class #1393

merged 9 commits into from
Jul 30, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jul 16, 2024

Currently it is not possible to use the QFT class with density_matrix=True.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the enhancement New feature or request label Jul 16, 2024
@renatomello renatomello added this to the Qibo 0.2.10 milestone Jul 16, 2024
@renatomello renatomello self-assigned this Jul 16, 2024
@renatomello renatomello marked this pull request as ready for review July 16, 2024 10:59
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (d8cc501) to head (4a3b371).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1393   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          78       78           
  Lines       11192    11192           
=======================================
  Hits        11191    11191           
  Misses          1        1           
Flag Coverage Δ
unittests 99.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@renatomello renatomello added this pull request to the merge queue Jul 30, 2024
Merged via the queue into master with commit e40eb1c Jul 30, 2024
25 checks passed
@renatomello renatomello deleted the qft branch July 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants