-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpiling double bracket iterations into hamiltonian simulation #1294
base: master
Are you sure you want to change the base?
Conversation
…_scheduling_polynomial; test_double_bracket_iteration_scheduling_grid_hyperopt
#This will contain a class inheriting from double bracket and it will extend it by connecting to functionalities of TrotterHamiltonian
… the gaps. Next simplify, assume the oracles are numpy and then pass on to Matteo, Andrea, Edoardo to generalize the code to be backend independent
…qibo into DBI_transpiling_code_structure
…g for frame shifting
…p of evolution oracle
…p of evolution oracle
for more information, see https://pre-commit.ci
… seems, see the test notebook gci canonical
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o dbi_magnetic_field
…o dbi_magnetic_field
np.trace(Gamma_list[0] @ A) + np.trace(dGamma[0] @ d + Gamma_list[1] @ A) * s | ||
) | ||
for n in range(2, 4): | ||
dGamma.append(dGamma_diDiagonal(d, H, n, i, dGamma, Gamma_list)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here dbi_object
is missing as input of dGamma_diDiagonal
. About the naming, follow Python convention (https://peps.python.org/pep-0008/#naming-conventions), i.e. function names should be lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wrightjandrew tomorrow Andrea will join us until 9:30 AM EU and we can ask more about your PR (your branch was merged into this one and this is something you might need to update in your PR cost function)
…ased trotter steps limit
…com:qiboteam/qibo into DBI-transpiling-into-Hamiltonian-Simulation
…iboteam/qibo into DBI-transpiling-into-Hamiltonian-Simulation
…/github.com/qiboteam/qibo into DBI-transpiling-into-Hamiltonian-Simulation
…com:qiboteam/qibo into DBI-transpiling-into-Hamiltonian-Simulation
This reverts commit 976989e.
…the master from the Cost DBI PR
@Edoardo-Pedicillo @MatteoRobbiati @andrea-pasquale we realized that this revert commit This means that the master is affected to the pre #1287 state. The suggested fix is to merge this PR: the branch dbi_fix was merged into it this preserved the git blame history etc https://github.com/qiboteam/qibo/blame/DBI-transpiling-into-Hamiltonian-Simulation/src/qibo/models/dbi/double_bracket.py so the contribution is intact |
I see. I think that the easiest solution is just to open a small PR pointing to main that re-implements #1287. |
Yep, this was some 'auto merge' workflow and coredevs should merge in the future. We will prepare the PR. |
This is a draft (code works ok and preparing for review)
This PR delivers a workeable structure for further development.
The point is to:
More specifically
which is what I refer to as frame shifting
the
Checklist:
Checklist: