Usart driver #64
Merged
Usart driver #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
printf now prints the message and the task printing the message
Closed
Jchisholm204
added
bug
eparly
reviewed
Nov 23, 2023
JoshWAllen
reviewed
Nov 23, 2023
JoshWAllen
reviewed
Nov 23, 2023
JoshWAllen
reviewed
Nov 29, 2023
Comment on lines
+16
to
+18
| #define UART_WRITE_OK 0 | ||
| #define UART_ERR_UNDEF 1 | ||
| #define UART_ERR_ACC 2 |
There was a problem hiding this comment.
Nit: Could be replaced with an enum - not mandatory, more of a style preference. The biggest functional difference is scoping
|
Looks good, glad to see some solid documentation and comments. I don't want to block this going in for too long - I should be good to approve after all threads are resolved. |
|
Merging to move on with CAN bus drivers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.