ID admin tools, correct grammar #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for condescending-goldwasser-91acf0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
timvisee
reviewed
Nov 24, 2023
Comment on lines
+12
to
+13
| - [Locking](#locking) | ||
| - [Recovery mode](#recovery-mode) |
There was a problem hiding this comment.
Though I'm fine with listing these here, we also show them on the right in the table of contents.
| @@ -7,7 +7,12 @@ aliases: | |||
|
|
|||
| # Administration | |||
|
|
|||
| Qdrant exposes administration tools which enable to modify at runtime the behavior of a qdrant instance without changing its configuration manually. | |||
| Qdrant exposes administration tools which allow you to modify the behavior of a Qdrant instance at runtime: | |||
There was a problem hiding this comment.
Recovery mode is not a runtime thing, so the original text was wrong.
What do you think about simplifying it to this?
Suggested change
| Qdrant exposes administration tools which allow you to modify the behavior of a Qdrant instance at runtime: | |
| Qdrant exposes administration tools: |
There was a problem hiding this comment.
This is not the only page with Qdrant admin tools. I'd either change the title of this page, or maybe:
- Move "locking" next to Authentication.
- Even though "locking" is global, it's something that an admin would disable before others can create / add new data.
- Move "recovery mode" under Troubleshooting.
- While the page title is "Solving common errors," the ToC entry is "Troubleshooting"
I'm tempted to replace this PR with a "grammar only" change, and set up a new issue to organize all Qdrant admin tools: #423 . Does this make sense, @timvisee ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the intro to:
LockingandRecovery modewon't need to go further. Readers who don't know will have links to both.IMO, the whole page could use a good rewrite, but one step at a time.