Add version check on client init #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush008
reviewed
Dec 20, 2024
Anush008
reviewed
Dec 24, 2024
Comment on lines
+67
to
+95
| public static boolean isCompatible(String clientVersion, String serverVersion) { | ||
| if (clientVersion.isEmpty()) { | ||
| logger.warn("Unable to compare with client version {}", clientVersion); | ||
| return false; | ||
| } | ||
|
|
||
| if (serverVersion.isEmpty()) { | ||
| logger.warn("Unable to compare with server version {}", serverVersion); | ||
| return false; | ||
| } | ||
|
|
||
| if (clientVersion.equals(serverVersion)) { | ||
| return true; | ||
| } | ||
|
|
||
| try { | ||
| Version parsedServerVersion = parseVersion(serverVersion); | ||
| Version parsedClientVersion = parseVersion(clientVersion); | ||
|
|
||
| int majorDiff = Math.abs(parsedServerVersion.getMajor() - parsedClientVersion.getMajor()); | ||
| if (majorDiff >= 1) { | ||
| return false; | ||
| } | ||
| return Math.abs(parsedServerVersion.getMinor() - parsedClientVersion.getMinor()) <= 1; | ||
| } catch (IllegalArgumentException e) { | ||
| logger.warn("Unable to compare versions: {}", e.getMessage()); | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| public static boolean isCompatible(String clientVersion, String serverVersion) { | |
| if (clientVersion.isEmpty()) { | |
| logger.warn("Unable to compare with client version {}", clientVersion); | |
| return false; | |
| } | |
| if (serverVersion.isEmpty()) { | |
| logger.warn("Unable to compare with server version {}", serverVersion); | |
| return false; | |
| } | |
| if (clientVersion.equals(serverVersion)) { | |
| return true; | |
| } | |
| try { | |
| Version parsedServerVersion = parseVersion(serverVersion); | |
| Version parsedClientVersion = parseVersion(clientVersion); | |
| int majorDiff = Math.abs(parsedServerVersion.getMajor() - parsedClientVersion.getMajor()); | |
| if (majorDiff >= 1) { | |
| return false; | |
| } | |
| return Math.abs(parsedServerVersion.getMinor() - parsedClientVersion.getMinor()) <= 1; | |
| } catch (IllegalArgumentException e) { | |
| logger.warn("Unable to compare versions: {}", e.getMessage()); | |
| return false; | |
| } | |
| } | |
| public static boolean isCompatible(String clientVersion, String serverVersion) { | |
| try { | |
| Version client = parseVersion(clientVersion); | |
| Version server = parseVersion(serverVersion); | |
| if (client.getMajor() != server.getMajor()) return false; | |
| return Math.abs(client.getMinor() - server.getMinor()) <= 1; | |
| } catch (IllegalArgumentException e) { | |
| logger.warn("Version comparison failed: {}", e.getMessage()); | |
| return false; | |
| } | |
| } |
Could be simpler like this I think.
Anush008
reviewed
Dec 24, 2024
Comment on lines
+48
to
+53
| String rest = | ||
| parts.length > 2 | ||
| ? String.join(".", new ArrayList<>(Arrays.asList(parts).subList(2, parts.length))) | ||
| : ""; | ||
|
|
||
| return new Version(major, minor, rest); |
There was a problem hiding this comment.
rest part of the version is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send request to fetch server version during client init and compare with client version.
Introduce an optional
checkCompatibilityparam (true by default). If it is true -> check versions during client init and generate a warning if versions are not compatible. Compatible versions are the ones that differ by one, i.e client version 1.6.x is compatible with server versions 1.5.x and 1.7.x but not 1.4.x or 1.8.x.