Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nop slf4j for tests #28

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

russcam
Copy link
Collaborator

@russcam russcam commented Apr 15, 2024

This PR adds nop slf4j test dependency, to suppress noProviders warning.

It also fixes a couple of small suggestions.

russcam added 2 commits April 15, 2024 17:49
This commit adds nop slf4j test dependency, to suppress noProviders warning.
@russcam russcam requested a review from Anush008 April 15, 2024 07:52
@russcam russcam changed the title Russcam noop slf4j tests Add nop slf4j for tests Apr 15, 2024
Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@Anush008 Anush008 merged commit 68729a5 into qdrant:master Apr 15, 2024
2 checks passed
@russcam russcam deleted the russcam-noop-slf4j-tests branch April 15, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants