Apply suggestions from code review

Co-authored-by: Russ Cam <[email protected]>
qdrant · Jan 6, 2024 · 2754387 · 2754387
1 parent ecd3c7c
commit 2754387
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/io/qdrant/client/QdrantClient.java b/src/main/java/io/qdrant/client/QdrantClient.java
@@ -2257,13 +2257,16 @@ public ListenableFuture<UpdateBatchResponse> batchUpdateAsync(
 	 * 
 	 * @return a new instance of {@link ListenableFuture}
 	 */
-	public ListenableFuture<UpdateBatchResponse> batchUpdateAsync(UpdateBatchPoints request, @Nullable Duration timeout) {
+	public ListenableFuture<List<UpdateResult>> batchUpdateAsync(UpdateBatchPoints request, @Nullable Duration timeout) {
 		String collectionName = request.getCollectionName();
 		Preconditions.checkArgument(!collectionName.isEmpty(), "Collection name must not be empty");
 		logger.debug("Batch update points on '{}'", collectionName);
 		ListenableFuture<UpdateBatchResponse> future = getPoints(timeout).updateBatch(request);
 		addLogFailureCallback(future, "Batch update points");
-		return future;
+		return Futures.transform(
+			future,
+			UpdateBatchResponse::getResultList,
+			MoreExecutors.directExecutor());
 	}
 
 	/**

diff --git a/src/main/java/io/qdrant/client/VectorsFactory.java b/src/main/java/io/qdrant/client/VectorsFactory.java
@@ -25,7 +25,7 @@ private VectorsFactory() {
 	public static Vectors namedVectors(Map<String, Vector> values) {
 		return Vectors.newBuilder()
 			.setVectors(NamedVectors.newBuilder()
-				.putAllVectors(Maps.transformValues(values, v -> v))
+				.putAllVectors(values)
 			)
 			.build();
 	}