Check if server's and client's versions are compatible #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush008
reviewed
Dec 19, 2024
Anush008
reviewed
Dec 24, 2024
| return &Version{ | ||
| Major: major, | ||
| Minor: minor, | ||
| Rest: rest, |
There was a problem hiding this comment.
Rest is not used for any compatibility checks.
Anush008
reviewed
Dec 24, 2024
Comment on lines
+73
to
+93
| func IsCompatible(clientVersion, serverVersion *string) bool { | ||
| if *clientVersion == *serverVersion { | ||
| return true | ||
| } | ||
|
|
||
| parsedClientVersion, err := ParseVersion(*clientVersion) | ||
| if err != nil { | ||
| log.Printf("Unable to compare versions: %v", err) | ||
| return false | ||
| } | ||
| parsedServerVersion, err := ParseVersion(*serverVersion) | ||
| if err != nil { | ||
| log.Printf("Unable to compare versions: %v", err) | ||
| return false | ||
| } | ||
| majorDiff := int(math.Abs(float64(parsedClientVersion.Major - parsedServerVersion.Major))) | ||
| if majorDiff >= 1 { | ||
| return false | ||
| } | ||
| return int(math.Abs(float64(parsedClientVersion.Minor-parsedServerVersion.Minor))) <= 1 | ||
| } |
There was a problem hiding this comment.
Suggested change
| func IsCompatible(clientVersion, serverVersion *string) bool { | |
| if *clientVersion == *serverVersion { | |
| return true | |
| } | |
| parsedClientVersion, err := ParseVersion(*clientVersion) | |
| if err != nil { | |
| log.Printf("Unable to compare versions: %v", err) | |
| return false | |
| } | |
| parsedServerVersion, err := ParseVersion(*serverVersion) | |
| if err != nil { | |
| log.Printf("Unable to compare versions: %v", err) | |
| return false | |
| } | |
| majorDiff := int(math.Abs(float64(parsedClientVersion.Major - parsedServerVersion.Major))) | |
| if majorDiff >= 1 { | |
| return false | |
| } | |
| return int(math.Abs(float64(parsedClientVersion.Minor-parsedServerVersion.Minor))) <= 1 | |
| } | |
| func IsCompatible(clientVersion, serverVersion string) bool { | |
| if clientVersion == serverVersion { | |
| return true | |
| } | |
| client, err := ParseVersion(clientVersion) | |
| if err != nil { | |
| log.Printf("Unable to compare versions: %v", err) | |
| return false | |
| } | |
| server, err := ParseVersion(serverVersion) | |
| if err != nil { | |
| log.Printf("Unable to compare versions: %v", err) | |
| return false | |
| } | |
| if client.Major != server.Major { | |
| return false | |
| } | |
| diff := client.Minor - server.Minor | |
| return diff <= 1 && diff >= -1 | |
| } |
Could be simpler.
Anush008
reviewed
Dec 24, 2024
| logger.Warn("Failed to obtain server version. " + | ||
| "Unable to check client-server compatibility. " + | ||
| "Set SkipCompatibilityCheck=true to skip version check.") | ||
| } else if !IsCompatible(&clientVersion, &serverVersion) { |
There was a problem hiding this comment.
Suggested change
| } else if !IsCompatible(&clientVersion, &serverVersion) { | |
| } else if !IsCompatible(clientVersion, serverVersion) { |
Anush008
reviewed
Dec 24, 2024
| for _, test := range tests { | ||
| clientVersion := test.clientVersion | ||
| serverVersion := test.serverVersion | ||
| result := qdrant.IsCompatible(&clientVersion, &serverVersion) |
There was a problem hiding this comment.
Suggested change
| result := qdrant.IsCompatible(&clientVersion, &serverVersion) | |
| result := qdrant.IsCompatible(clientVersion, serverVersion) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send request to fetch server version during client init and compare with client version.
Introduce a boolean param SkipCompatibilityCheck (false by default). If it is false -> check versions during client init and generate a warning if versions are not compatible. Compatible versions are the ones that differ by one, i.e client version 1.6.x is compatible with server versions 1.5.x and 1.7.x but not 1.4.x or 1.8.x.