-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Add Torrent experience to WebUI #21645
Draft
Piccirello
wants to merge
12
commits into
qbittorrent:master
Choose a base branch
from
Piccirello:metadata-webui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,403
−1,247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piccirello
force-pushed
the
metadata-webui
branch
5 times, most recently
from
November 3, 2024 21:58
9317683
to
815976c
Compare
Signed-off-by: Thomas Piccirello <[email protected]>
Signed-off-by: Thomas Piccirello <[email protected]>
Signed-off-by: Thomas Piccirello <[email protected]>
Signed-off-by: Thomas Piccirello <[email protected]>
Signed-off-by: Thomas Piccirello <[email protected]>
Previously we would still download the file but it would contain the error response. Signed-off-by: Thomas Piccirello <[email protected]>
This logic was tightly coupled with the prop-files table. Signed-off-by: Thomas Piccirello <[email protected]>
This dialog more closely mimics the dialog presented by the GUI. It includes information about the contents of a torrent. Signed-off-by: Thomas Piccirello <[email protected]>
This is done in a separate commit to avoid losing revision history.
Signed-off-by: Thomas Piccirello <[email protected]>
Signed-off-by: Thomas Piccirello <[email protected]>
Piccirello
force-pushed
the
metadata-webui
branch
from
November 8, 2024 18:01
815976c
to
bf1d3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new APIs from #21015 to provide a WebUI Add Torrent experience more closely matching the GUI's.
This PR will be rebased and taken out of draft mode once #21015 is merged.
Closes #20557.
Before:
After:
GUI, for comparison: