Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Add Torrent experience to WebUI #21645

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Piccirello
Copy link
Member

@Piccirello Piccirello commented Oct 19, 2024

This PR uses the new APIs from #21015 to provide a WebUI Add Torrent experience more closely matching the GUI's.

This PR will be rebased and taken out of draft mode once #21015 is merged.

Closes #20557.

Before:
before

After:
after

GUI, for comparison:
gui

@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Oct 19, 2024
@Piccirello Piccirello added this to the 5.1 milestone Oct 19, 2024
@Piccirello Piccirello force-pushed the metadata-webui branch 5 times, most recently from 9317683 to 815976c Compare November 3, 2024 21:58
Previously we would still download the file but it would contain the error response.

Signed-off-by: Thomas Piccirello <[email protected]>
This logic was tightly coupled with the prop-files table.

Signed-off-by: Thomas Piccirello <[email protected]>
This dialog more closely mimics the dialog presented by the GUI. It includes information about the contents of a torrent.

Signed-off-by: Thomas Piccirello <[email protected]>
This is done in a separate commit to avoid losing revision history.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebUI doesn't indicate when invalid or semi-invalid torrents/magnets are being added
1 participant