-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free resources allocated by web session once it is destructed #21618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dyseg |
Chocobo1
reviewed
Oct 15, 2024
This was referenced Oct 16, 2024
I would go Qt way and set session to be parent of controllers. Just add void WebSession::registerAPIController(const QString &scope, APIController *controller)
{
Q_ASSERT(controller);
m_apiControllers[scope] = controller;
controller->setParent(this);
} |
glassez
changed the title
WebUI: fix memory leak
Free resources allocated by web session once it is destructed
Oct 16, 2024
glassez
added
Core
WebAPI
WebAPI-related issues/changes
and removed
WebUI
WebUI-related issues/changes
labels
Oct 16, 2024
@glassez |
glassez
previously approved these changes
Oct 16, 2024
Chocobo1
previously approved these changes
Oct 17, 2024
Chocobo1
reviewed
Oct 17, 2024
glassez
approved these changes
Oct 19, 2024
Chocobo1
approved these changes
Oct 20, 2024
@dyseg |
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Oct 21, 2024
This was referenced Oct 21, 2024
Closed
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20873. Maybe also #20675.
More explanation in: #20873 (comment)