-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect sorting by "private" column #21041
Conversation
Maybe unrelated but i may as well mention it here (not caused by this PR): Assertion when adding a magnet link from WebUI:
|
Should it not display like below?? (like it would if you put those values in excel sheet for example)
|
This comment was marked as off-topic.
This comment was marked as off-topic.
I suppose Excel just sorts it alphabetically while we logically. |
I'd prefer alphabetical sorting, but that's just me...will not be a blocker. |
Should be fixed now. Could you confirm? |
Fixed 👍 |
@qbittorrent/bug-handlers, could someone approve it? |
src/gui/transferlistsortmodel.cpp
Outdated
return threeWayCompare(left.toBool(), right.toBool()); | ||
if (!leftValid && !rightValid) | ||
return 0; | ||
return rightValid ? -1 : 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking. Usually it is return leftValid ? -1 : 1;
and here is special behavior, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here is special behavior, right?
Done by mistake. Fixed.
No description provided.