Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1402 Get CountRows from sheet #1403

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ivolkoff
Copy link

@ivolkoff ivolkoff commented Nov 25, 2022

PR Details

Get CountRows from sheet

Description

Get CountRows from sheet

Related Issue

#1402

Motivation and Context

Current solutions are slow. My solution is fast.

file 1М rows
| - | - | - |
|---|---|---|
| BenchmarkFile_GetRows_Old-8 | 1 | 5797898958 ns/op |
| BenchmarkFile_GetRows_New-8 | 3 | 411330472 ns/op |

How Has This Been Tested

Run test TestFile_CountRows

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2022
@xuri xuri force-pushed the master branch 2 times, most recently from 79958aa to 0c3dfb1 Compare May 25, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants