add auto fit columns function

[yyt030]

PR Details

add auto fit columns function

Description

add auto fit columns function

Related Issue

#92

Motivation and Context

How Has This Been Tested

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[xuri]

Thanks for your contribution, I've left some comments.

[Noah-Chiu]

Little suggestion for you guys:
Maybe can add the feature to check if the cell has the Chinese or Japanese or other bigger font type
For me I use unicode.Is to check the unicode.Han, and plus the column width for every single word

[xuri]

I have added some new comments, but there is some feedback in the previous review still not resolved.

[yyt030]

Little suggestion for you guys: Maybe can add the feature to check if the cell has the Chinese or Japanese or other bigger font type For me I use unicode.Is to check the unicode.Han, and plus the column width for every single word

I rewrite the function to calculate length of sbcs and mbcs.

[xuri]

We can't fix the character width, which also related to the font family and font size style, we need to consider this factor.

[hq2333]

Has this pull request not been merged into master yet?

[xuri]

Has this pull request not been merged into master yet?

There are some code review issues still not resolved. We need to resolve these issues before merging it into the master branch.

[n3m]

What's missing for this PR to be merged? All conversations on the "Files" tab seem to be resolved (although idk if truly accepted).

If there's still logic pending for review, broken or missing, I might be able to help.

[edwardmatutino]

need this feature. any updates

[xuri]

Hi @yyt030, @n3m, @edwardmatutino, the character width is related to the font family and font size style, we need to calculate column width by font size. I have marked the unresolved comments in the code review conversion. In addition, there's a code conflict in this pull request, we need to resolve this for merging this, and before that please also reference the code in issues #92 and #204.

[xuxxxxxx0249]

Is this feature available now?

[xuri]

Is this feature available now?

Not available. The code review issues as I mentioned above should be fixed.