Skip to content

Commit

Permalink
Fix SSD TBE tests for OSS (pytorch#2665)
Browse files Browse the repository at this point in the history
Summary:
- Fix SSD TBE test for OSS

Pull Request resolved: pytorch#2665

Reviewed By: sryap, spcyppt

Differential Revision: D58099204

Pulled By: q10

fbshipit-source-id: 5705c8d0021392189c8aa41978f5bd387c70a05c
  • Loading branch information
q10 authored and facebook-github-bot committed Jun 4, 2024
1 parent b7e6ce4 commit b3f8fd8
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
6 changes: 3 additions & 3 deletions .github/scripts/fbgemm_gpu_test.bash
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ run_python_test () {

__configure_fbgemm_gpu_test_cpu () {
ignored_tests=(
./ssd_split_table_batched_embeddings_test.py
./tbe/ssd/ssd_split_table_batched_embeddings_test.py
# These tests have non-CPU operators referenced in @given
./uvm/copy_test.py
./uvm/uvm_test.py
Expand All @@ -77,7 +77,7 @@ __configure_fbgemm_gpu_test_cpu () {

__configure_fbgemm_gpu_test_cuda () {
ignored_tests=(
./ssd_split_table_batched_embeddings_test.py
./tbe/ssd/ssd_split_table_batched_embeddings_test.py
# require multiple GPUs
./comm/multi_gpu_car_test.py
)
Expand All @@ -102,7 +102,7 @@ __configure_fbgemm_gpu_test_rocm () {
fi

ignored_tests=(
./ssd_split_table_batched_embeddings_test.py
./tbe/ssd/ssd_split_table_batched_embeddings_test.py
# https://github.com/pytorch/FBGEMM/issues/1559
./batched_unary_embeddings_test.py
# require multiple GPUs
Expand Down
20 changes: 12 additions & 8 deletions fbgemm_gpu/fbgemm_gpu/ssd_split_table_batched_embeddings_ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,18 @@
"//deeplearning/fbgemm/fbgemm_gpu:ssd_split_table_batched_embeddings_hip"
)
else:
torch.ops.load_library(
"//deeplearning/fbgemm/fbgemm_gpu:ssd_split_table_batched_embeddings"
)
except OSError:
# Keep for BC: will be deprecated soon.
torch.ops.load_library(
"//deeplearning/fbgemm/fbgemm_gpu/fb:ssd_split_table_batched_embeddings"
)
try:
torch.ops.load_library(
"//deeplearning/fbgemm/fbgemm_gpu:ssd_split_table_batched_embeddings"
)
except OSError:
# Keep for BC: will be deprecated soon.
torch.ops.load_library(
"//deeplearning/fbgemm/fbgemm_gpu/fb:ssd_split_table_batched_embeddings"
)
except Exception:
pass


ASSOC = 32

Expand Down

0 comments on commit b3f8fd8

Please sign in to comment.