Fix git checkout typo in readme #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
reviewed
Oct 18, 2022
| @@ -143,11 +143,14 @@ Both `docker` and `pip install` options above are wrappers around the `cmake bui | |||
| #### Building | |||
|
|
|||
| ```bash | |||
| # Setup deps | |||
| conda install -c conda-forge libpython-static | |||
There was a problem hiding this comment.
this is mentioned in the section before
There was a problem hiding this comment.
Yeah, so like I skipped to the build from source section, it didn't work, and then I had to go back and look for it. Just put it close lol
There was a problem hiding this comment.
maybe we just add a line about "make sure to install python static as mentioned earlier"
d4l3k
reviewed
Oct 25, 2022
| @@ -143,11 +143,14 @@ Both `docker` and `pip install` options above are wrappers around the `cmake bui | |||
| #### Building | |||
|
|
|||
| ```bash | |||
| # Setup deps | |||
| conda install -c conda-forge libpython-static | |||
There was a problem hiding this comment.
maybe we just add a line about "make sure to install python static as mentioned earlier"
| @@ -157,6 +160,7 @@ cd multipy/runtime | |||
| mkdir build | |||
| cd build | |||
| # use cmake -DABI_EQUALS_1=ON .. instead if you want ABI=1 | |||
| # if you built PyTorch from source, pass -DPYTORCH_ROOT=path/to/pytorch | |||
There was a problem hiding this comment.
This line isn't needed with recent changes. Also does this work given we always set it in cmake?
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
Summary: This updates the README with some feedback from #212 as well as adds a CHANGELOG for the 0.1 release. Pull Request resolved: #229 Test Plan: docs only Reviewed By: anirbanr-fb-r2p, PaliC Differential Revision: D40691024 Pulled By: d4l3k fbshipit-source-id: 7b76f7cbc7dc4dbd243b5879f510e3dd8a7c9b59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.