Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore return value of function declared with 'warn_unused_result' #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deklov
Copy link

@deklov deklov commented Aug 31, 2022

Summary:
Ignore return value of function declared with 'warn_unused_result'

Addresses the following build failure that we get on some of our internal build environments:
caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str());

Differential Revision: D39181069

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Aug 31, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39181069

@PaliC PaliC self-requested a review August 31, 2022 21:35
Copy link
Contributor

@PaliC PaliC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

deklov pushed a commit to deklov/multipy that referenced this pull request Sep 7, 2022
…84369)

Summary:
X-link: pytorch/pytorch#84369

Pull Request resolved: pytorch#152

Ignore return value of function declared with 'warn_unused_result'

Addresses the following build failure that we get on some of our internal build environments:
caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str());

Reviewed By: jiyuanzFB, PaliC

Differential Revision: D39181069

fbshipit-source-id: 6b4daeba829d074f2a217e34daf97bbc4dd8afd4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39181069

deklov pushed a commit to deklov/pytorch that referenced this pull request Sep 7, 2022
…ytorch#84369)

Summary:
Pull Request resolved: pytorch#84369

X-link: pytorch/multipy#152

Ignore return value of function declared with 'warn_unused_result'

Addresses the following build failure that we get on some of our internal build environments:
caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str());

Test Plan: Successful build

Reviewed By: jiyuanzFB, PaliC

Differential Revision: D39181069

fbshipit-source-id: e571b09c6da9ca3dcac2b5eaf9f8a3f8473adefd
deklov pushed a commit to deklov/multipy that referenced this pull request Sep 7, 2022
…84369)

Summary:
X-link: pytorch/pytorch#84369

Pull Request resolved: pytorch#152

Ignore return value of function declared with 'warn_unused_result'

Addresses the following build failure that we get on some of our internal build environments:
caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str());

Reviewed By: jiyuanzFB, PaliC

Differential Revision: D39181069

fbshipit-source-id: 953eb9e51fd15859bc435b04a1565924865a4b14
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39181069

…84369)

Summary:
X-link: pytorch/pytorch#84369

Pull Request resolved: pytorch#152

Ignore return value of function declared with 'warn_unused_result'

Addresses the following build failure that we get on some of our internal build environments:
caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str());

Reviewed By: jiyuanzFB, PaliC

Differential Revision: D39181069

fbshipit-source-id: 103ebd9529ac5d947f18a22e3fc6294341d246a4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39181069

@facebook-github-bot
Copy link
Contributor

Hi @deklov!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants