Skip to content

Commit

Permalink
remove python 3.7 support
Browse files Browse the repository at this point in the history
ghstack-source-id: 3698d6c936ac1caa7df9abdba78626aa971f2310
Pull Request resolved: #314
  • Loading branch information
PaliC committed Apr 10, 2023
1 parent e271d85 commit b4640bc
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 31 deletions.
33 changes: 8 additions & 25 deletions .github/workflows/build_test_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,24 +40,10 @@ jobs:
echo "::endgroup::"
echo "::group::Setup virtual environment"
if [[ ${{ inputs.python3-minor-version }} -gt 7 ]];
then
conda install -y python=${python_version} mkl mkl-include conda-build pyyaml numpy ipython
conda install -y -c conda-forge libpython-static=${python_version}
conda install -y pytorch torchvision torchaudio cpuonly -c pytorch
conda clean -ya;
else
conda deactivate
pip install virtualenv
git clone https://github.com/pyenv/pyenv.git ~/.pyenv
export CFLAGS="-fPIC -g"
~/.pyenv/bin/pyenv install --force ${python_version}
virtualenv -p ~/.pyenv/versions/$(~/.pyenv/bin/pyenv latest ${python_version})/bin/python3 ~/venvs/multipy
source ~/venvs/multipy/bin/activate
pip install \
torch torchvision torchaudio \
--extra-index-url https://download.pytorch.org/whl/cpu;
fi
conda install -y python=${python_version} mkl mkl-include pyyaml numpy ipython
conda install -y -c conda-forge libpython-static=${python_version}
conda install -y pytorch torchvision torchaudio cpuonly -c pytorch
conda clean -ya;
echo "::endgroup::"
echo "::group::Install"
Expand Down Expand Up @@ -94,13 +80,10 @@ jobs:
./multipy/runtime/build/deploy_benchmark 2 none jit multipy/runtime/example/generated/resnet
echo "::endgroup::"
if [[ ${{ inputs.python3-minor-version }} -gt 7 ]];
then
echo "::group::Compat test"
pip install -r compat-requirements.txt
multipy/runtime/build/interactive_embedded_interpreter --pyscript multipy/runtime/test_compat.py
echo "::endgroup::";
fi
echo "::group::Compat test"
pip install -r compat-requirements.txt
multipy/runtime/build/interactive_embedded_interpreter --pyscript multipy/runtime/test_compat.py
echo "::endgroup::";
echo "::group::Test GPU"
# Separating GPU tests due to issues with py37 and py38: https://github.com/pytorch/multipy/issues/239
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/install_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
installtest:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [ubuntu-18.04]
fail-fast: false
runs-on: ${{ matrix.platform }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/runtime_nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
build-test-release:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [linux.4xlarge.nvidia.gpu]
fail-fast: false
uses: ./.github/workflows/build_test_release.yaml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/runtime_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
unittest:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [linux.4xlarge.nvidia.gpu]
fail-fast: false
uses: ./.github/workflows/build_test_release.yaml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_docker_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
unittest:
strategy:
matrix:
python3-minor-version: [7,8,9,10]
python3-minor-version: [8,9,10]
platform: [linux.4xlarge.nvidia.gpu]
fail-fast: false
runs-on: ${{ matrix.platform }}
Expand Down
4 changes: 2 additions & 2 deletions multipy/runtime/test_compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def test_torchvision(self):
def test_torchaudio(self):
import torchaudio # noqa: F401

def test_pytorch3d(self):
import pytorch3d # noqa: F401
# def test_pytorch3d(self):
# import pytorch3d # noqa: F401

def test_hf_tokenizers(self):
import tokenizers # noqa: F401
Expand Down

0 comments on commit b4640bc

Please sign in to comment.