make CollectTrace for profiling by iteration async #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!stopByIterThread) { | ||
| std::lock_guard<std::mutex> guard(mutex_); | ||
| if (!stopByIterThread) { | ||
| stopByIterThread = new std::thread([collection_done, this, now](){ |
| std::lock_guard<std::mutex> guard(mutex_); | ||
| if (stopByIterThread) { | ||
| stopByIterThread->join(); | ||
| delete stopByIterThread; |
There was a problem hiding this comment.
with unique ptr this woudl be stopByIterThread.reset()
|
Thank you for those helpful tips, I'll improve this pr as comments advised. |
staugust
force-pushed
the
main2
branch
2 times, most recently
from
2bfb538
to
1af59c6
Compare
|
@briancoutinho It seems this pr is ignored after last commit. I've rebased master branch, please take some time to re-review this pr, thank you. |
|
Hi, sorry am out for 1 1/2 week, will take a look once I'm back. you can
also ask @
sraikund16 for a review
Thx
…On Fri, Aug 30, 2024 at 12:38 AM Augusto Yao ***@***.***> wrote:
@briancoutinho <https://github.com/briancoutinho> It seems this pr is
ignored after last commit. I've rebased master branch, please take some
time to re-review this pr, thank you.
—
Reply to this email directly, view it on GitHub
<#966 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUZ7ZCZM47WFP4YYUGFAELZUAOOLAVCNFSM6AAAAABLQGOI7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGM2TMMRUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@briancoutinho it's ok. @sraikund16 would you like to review this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix issue #953. Makes
libkineto::api().client()->stop()andstopTraceInternalrun inprofilerThread_so that, the training process will not be blocked.