-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added skip_bos Argument to LLM Attribution To Enable Wider Model Support for Attributing Against a Single Token #1322
base: master
Are you sure you want to change the base?
Conversation
Fixed an issue where when trying to attribute a single target token for models that don't generate a bos you end up with an empty target list
Added some error handling for when the argument should be used
Added exit to try except loop
Hi @SulRash! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @SulRash , this looks great! From the CI results, it looks like the lint / ufmt checks are failing, would you be able to resolve that?
Also, ideally we can add the same argument to LLMGradientAttribution for consistency, but we can add that in a separate PR as well.
Thanks again for the contribution!
Hey @vivekmig! Oh yeah, that's actually such a good idea, I'll submit a separate PR request for that class! |
Just fixed the linting issue, should be fine now :) |
Some models do not generate a bos, so when trying to attribute a single token the code crashes. I added a
skip_bos
argument (that defaults to True to not change anything in the system) and some minor error handling to tell the user when to use the argument.Here's my error handling so far:
This allowed me to attribute multiple choice question answers (a single token) with models (like microsoft/Phi-3-mini-4k-instruct) that don't generate a bos token when the target is predefined.
The error that would pop up without this change is the following: