support quantize_fp8_row for up to 4d non contiguous tensor #3508
+97
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67303282 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hhyuanf
pushed a commit
to hhyuanf/FBGEMM-1
that referenced
this pull request
Dec 16, 2024
…3508) Summary: X-link: facebookresearch/FBGEMM#589 reland D66990975 with fix for the NaN issued observed during LLaMa4 17B model run with fp8_rowwise FFN Specifically, offset was not properly updated when loading/storing data. Differential Revision: D67303282
hhyuanf
force-pushed
the
export-D67303282
branch
from
c863b9a to
9d0dd32
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67303282 |
hhyuanf
pushed a commit
to hhyuanf/FBGEMM-1
that referenced
this pull request
Dec 16, 2024
…3508) Summary: X-link: facebookresearch/FBGEMM#589 reland D66990975 with fix for the NaN issued observed during LLaMa4 17B model run with fp8_rowwise FFN Specifically, offset was not properly updated when loading/storing data. Differential Revision: D67303282
hhyuanf
force-pushed
the
export-D67303282
branch
from
9d0dd32 to
0b9537a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67303282 |
hhyuanf
pushed a commit
to hhyuanf/FBGEMM-1
that referenced
this pull request
Dec 17, 2024
…3508) Summary: X-link: facebookresearch/FBGEMM#589 reland D66990975 with fix for the NaN issued observed during LLaMa4 17B model run with fp8_rowwise FFN Specifically, offset was not properly updated when loading/storing data. Differential Revision: D67303282
hhyuanf
force-pushed
the
export-D67303282
branch
from
0b9537a to
8495846
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67303282 |
…3508) Summary: X-link: facebookresearch/FBGEMM#589 reland D66990975 with fix for the NaN issued observed during LLaMa4 17B model run with fp8_rowwise FFN Specifically, offset was not properly updated when loading/storing data. Differential Revision: D67303282
hhyuanf
force-pushed
the
export-D67303282
branch
from
8495846 to
dcbfabd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67303282 |
|
This pull request has been merged in eaa0961. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
reland D66990975 with fix for the NaN issued observed during LLaMa4 17B model run with fp8_rowwise FFN
Specifically, offset was not properly updated when loading/storing data.
Differential Revision: D67303282