Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for int32_t indices #3319

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

q10
Copy link
Contributor

@q10 q10 commented Nov 3, 2024

Summary:

  • Update template instantiations of v2 and nobag kernels to address undefined symbols error

  • Fix hash_size_cumsum in transpose_embedding_input to accept int64_t only

Differential Revision: D62794566

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62794566

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 3bf2ee8
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6734649ae0a01600080f3385
😎 Deploy Preview https://deploy-preview-3319--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 4, 2024
Summary:

- Update template instantiations of v2 and nobag kernels to address undefined symbols error

- Fix `hash_size_cumsum` in `transpose_embedding_input` to accept `int64_t` only

Differential Revision: D62794566
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62794566

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 4, 2024
Summary:
X-link: facebookresearch/FBGEMM#414


- Update template instantiations of v2 and nobag kernels to address undefined symbols error

- Fix `hash_size_cumsum` in `transpose_embedding_input` to accept `int64_t` only

Differential Revision: D62794566
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62794566

Summary:
X-link: facebookresearch/FBGEMM#412


INT32 support

Differential Revision: D62395317
Summary:
X-link: facebookresearch/FBGEMM#414


- Update template instantiations of v2 and nobag kernels to address undefined symbols error

- Fix `hash_size_cumsum` in `transpose_embedding_input` to accept `int64_t` only

Differential Revision: D62794566
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62794566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants