Sign petition with an account #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallen
reviewed
Oct 2, 2020
| 'email': pytitionuser.user.email | ||
| } | ||
|
|
||
| sign_form = SignatureForm(petition=petition, initial=initial) |
There was a problem hiding this comment.
This looks great!
Could you add one unit test for this new feature?
Just check that if a user is logged in, its personal information are displayed in the HTML form and that
form.is_bound == True?
fallen
reviewed
Oct 2, 2020
lpoujade
force-pushed
the
99_sign_with_account
branch
from
1bf5319 to
9be2672
Compare
|
I can see you've rebased on origin/master. |
|
yes i just don't had the time until this week, i finish that at the end of the week :) |
|
Absolutely no problem! |
fallen
force-pushed
the
master
branch
2 times, most recently
from
c285207 to
2037088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition for #99 : auto fill petition's signature form with currently connected user, if any, else leave form empty