Fix typos discovered by codespell #18387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cdce8p
suggested changes
Dec 30, 2024
| @@ -100,6 +100,10 @@ force-exclude = ''' | |||
| ^/test-data | |||
| ''' | |||
|
|
|||
| [tool.codespell] | |||
| ignore-words-list = "ans,ccompiler,corus,fo,froms,haa,hax,notin,ot,statics,whet,zar" | |||
There was a problem hiding this comment.
2.3.0 added inline ignores. We should probably use those for single occurrences like froms.
# codespell:ignore froms| @@ -100,6 +100,10 @@ force-exclude = ''' | |||
| ^/test-data | |||
| ''' | |||
|
|
|||
| [tool.codespell] | |||
| ignore-words-list = "ans,ccompiler,corus,fo,froms,haa,hax,notin,ot,statics,whet,zar" | |||
| skip = "./mypyc/external/*,*.pyi,*.test" | |||
There was a problem hiding this comment.
I do wonder if we should just skip the whole mypy/test/ and mypyc/test folders entirely.
Personally I'd also just move the config to .pre-commit-config.yaml directly. Don't think any one is ever running codespell outside pre-commit.
This also allows us to use the pre-commit files filter as well with exclude_types: [pyi, test] and exclude: ^(mypyc/external/|mypy/test|mypyc/test).
Co-authored-by: Marc Mueller <[email protected]>
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pypi.org/project/codespell