-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict_bytes by default #18371
Draft
hauntsaninja
wants to merge
2
commits into
python:master
Choose a base branch
from
hauntsaninja:default-strict-bytes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+32
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
force-pushed
the
default-strict-bytes
branch
from
December 30, 2024 03:18
0e4649c
to
0bbeed5
Compare
This comment has been minimized.
This comment has been minimized.
hauntsaninja
force-pushed
the
default-strict-bytes
branch
from
December 30, 2024 04:59
0bbeed5
to
c39f026
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
hauntsaninja
force-pushed
the
default-strict-bytes
branch
from
December 30, 2024 06:11
f5c10aa
to
b6528b5
Compare
Diff from mypy_primer, showing the effect of this PR on open source code: websockets (https://github.com/aaugustin/websockets)
+ src/websockets/streams.py:52: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
+ src/websockets/streams.py:75: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
+ src/websockets/streams.py:97: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
+ src/websockets/frames.py:173: error: Argument 1 to "parse" of "Close" has incompatible type "bytes | bytearray | memoryview[int]"; expected "bytes" [arg-type]
+ src/websockets/frames.py:327: error: Argument 1 to "apply_mask" has incompatible type "bytes | bytearray | memoryview[int]"; expected "bytes" [arg-type]
+ src/websockets/frames.py:329: error: Incompatible types in assignment (expression has type "bytes | bytearray | memoryview[int]", variable has type "bytes") [assignment]
+ src/websockets/protocol.py:694: error: Argument 1 to "parse" of "Close" has incompatible type "bytes | bytearray | memoryview[int]"; expected "bytes" [arg-type]
+ src/websockets/extensions/permessage_deflate.py:137: error: Incompatible types in assignment (expression has type "bytes | bytearray | memoryview[int]", variable has type "bytes") [assignment]
+ src/websockets/extensions/permessage_deflate.py:194: error: Incompatible types in assignment (expression has type "memoryview[int]", variable has type "bytes") [assignment]
+ src/websockets/asyncio/messages.py:228: error: Incompatible types in "yield" (actual type "bytes | bytearray | memoryview[int]", expected type "str | bytes") [misc]
+ src/websockets/asyncio/messages.py:242: error: Incompatible types in "yield" (actual type "bytes | bytearray | memoryview[int]", expected type "str | bytes") [misc]
+ src/websockets/asyncio/connection.py:467: error: Argument 1 to "send_text" of "Protocol" has incompatible type "bytes | memoryview[Any]"; expected "bytes" [arg-type]
+ src/websockets/asyncio/connection.py:469: error: Argument 1 to "send_binary" of "Protocol" has incompatible type "bytes | memoryview[Any]"; expected "bytes" [arg-type]
+ src/websockets/sync/messages.py:224: error: Incompatible types in "yield" (actual type "bytes | bytearray | memoryview[int]", expected type "str | bytes") [misc]
+ src/websockets/sync/messages.py:235: error: Incompatible types in "yield" (actual type "bytes | bytearray | memoryview[int]", expected type "str | bytes") [misc]
+ src/websockets/legacy/framing.py:117: error: Argument 3 to "Frame" has incompatible type "bytes | bytearray | memoryview[int]"; expected "bytes" [arg-type]
+ src/websockets/sync/connection.py:431: error: Argument 1 to "send_text" of "Protocol" has incompatible type "bytes | memoryview[Any]"; expected "bytes" [arg-type]
+ src/websockets/sync/connection.py:433: error: Argument 1 to "send_binary" of "Protocol" has incompatible type "bytes | memoryview[Any]"; expected "bytes" [arg-type]
+ src/websockets/legacy/protocol.py:631: error: Argument 1 to "prepare_data" has incompatible type "str | bytes | memoryview[Any]"; expected "str | bytes" [arg-type]
git-revise (https://github.com/mystor/git-revise)
+ gitrevise/utils.py:85: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
operator (https://github.com/canonical/operator)
+ ops/pebble.py:3307: error: Argument 1 to "_next_part_boundary" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ ops/pebble.py:3323: error: Argument 1 has incompatible type "bytearray"; expected "bytes" [arg-type]
+ ops/pebble.py:3327: error: Argument 1 to "_next_part_boundary" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ ops/pebble.py:3331: error: Argument 1 to "__call__" of "_BodyHandler" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ ops/pebble.py:3338: error: Incompatible types in assignment (expression has type "bytearray", variable has type "bytes") [assignment]
aioredis (https://github.com/aio-libs/aioredis)
+ aioredis/connection.py:952: error: Argument 1 to "append" of "list" has incompatible type "bytes | memoryview[int]"; expected "bytes" [arg-type]
+ aioredis/connection.py:981: error: Subclass of "bytes" and "memoryview[Any]" cannot exist: "memoryview" is final [unreachable]
+ aioredis/connection.py:987: error: Subclass of "bytes" and "memoryview[Any]" cannot exist: "memoryview" is final [unreachable]
+ aioredis/client.py:1921: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2160: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2173: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2608: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2616: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2621: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2629: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2666: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:2674: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
+ aioredis/client.py:3176: error: Value of type variable "_KeyT" of "list_or_args" cannot be "Sequence[int] | str" [type-var]
dd-trace-py (https://github.com/DataDog/dd-trace-py)
+ ddtrace/internal/test_visibility/coverage_lines.py:73: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
bokeh (https://github.com/bokeh/bokeh)
+ src/bokeh/core/serialization.py: note: In member "_decode_bytes" of class "Deserializer":
+ src/bokeh/core/serialization.py:618:16: error: Incompatible return value type (got "bytes | memoryview[int]", expected "bytes") [return-value]
streamlit (https://github.com/streamlit/streamlit)
+ lib/streamlit/string_util.py: note: In function "is_binary_string":
+ lib/streamlit/string_util.py:164:37: error: Argument 2 to "translate" of "bytes" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ lib/streamlit/runtime/caching/hashing.py: note: In member "_to_bytes" of class "_CacheFuncHasher":
+ lib/streamlit/runtime/caching/hashing.py:363:20: error: Incompatible return value type (got "Union[bytes, bytearray]", expected "bytes") [return-value]
+ lib/streamlit/runtime/caching/hashing.py: note: At top level:
urllib3 (https://github.com/urllib3/urllib3)
+ src/urllib3/util/ssltransport.py:108: error: Argument 1 to "send" of "SSLTransport" has incompatible type "memoryview[int]"; expected "bytes" [arg-type]
+ test/test_ssltransport.py:57: error: Non-overlapping equality check (left operand type: "bytearray", right operand type: "str | bytes") [comparison-overlap]
+ test/test_ssltransport.py:548: error: Argument 1 to "sendall" of "SSLTransport" has incompatible type "bytearray"; expected "bytes" [arg-type]
boostedblob (https://github.com/hauntsaninja/boostedblob)
+ boostedblob/write.py:67: error: Argument "data" to "Request" has incompatible type "Union[bytes, bytearray, memoryview[int]]"; expected "Union[Dict[str, Any], bytes, None]" [arg-type]
+ boostedblob/write.py:88: error: Argument "data" to "Request" has incompatible type "Union[bytes, bytearray, memoryview[int]]"; expected "Union[Dict[str, Any], bytes, None]" [arg-type]
+ boostedblob/write.py:411: error: Argument "data" to "Request" has incompatible type "Union[bytes, bytearray, memoryview[int]]"; expected "Union[Dict[str, Any], bytes, None]" [arg-type]
mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
+ pymongo/message.py:739: error: Argument 1 to "_inflate_bson" has incompatible type "memoryview[int]"; expected "bytes" [arg-type]
+ pymongo/synchronous/network.py:331: error: Argument 1 to "decompress" has incompatible type "memoryview[int]"; expected "bytes" [arg-type]
+ pymongo/synchronous/network.py:333: error: Incompatible types in assignment (expression has type "memoryview[int]", variable has type "bytes") [assignment]
+ pymongo/asynchronous/network.py:333: error: Argument 1 to "decompress" has incompatible type "memoryview[int]"; expected "bytes" [arg-type]
+ pymongo/asynchronous/network.py:335: error: Incompatible types in assignment (expression has type "memoryview[int]", variable has type "bytes") [assignment]
+ pymongo/asynchronous/encryption.py:212: error: Incompatible types in assignment (expression has type "memoryview[int]", variable has type "bytes") [assignment]
trio (https://github.com/python-trio/trio)
+ src/trio/_unix_pipes.py:130: error: Argument 1 of "send_all" is incompatible with supertype "SendStream"; supertype defines the argument type as "Union[bytes, bytearray, memoryview[int]]" [override]
+ src/trio/_unix_pipes.py:130: note: This violates the Liskov substitution principle
+ src/trio/_unix_pipes.py:130: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ src/trio/_highlevel_generic.py:122: error: Incompatible return value type (got "Union[bytes, bytearray]", expected "bytes") [return-value]
+ src/trio/_tests/test_testing.py:423: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
+ src/trio/_tests/test_ssl.py:266: error: Argument 1 of "send_all" is incompatible with supertype "SendStream"; supertype defines the argument type as "Union[bytes, bytearray, memoryview[int]]" [override]
+ src/trio/_tests/test_ssl.py:266: note: This violates the Liskov substitution principle
+ src/trio/_tests/test_ssl.py:266: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ src/trio/_tests/test_dtls.py:465: error: No overload variant of "sendto" of "SocketType" matches argument types "Sequence[int]", "tuple[str, int]" [call-overload]
+ src/trio/_tests/test_dtls.py:465: note: Possible overload variants:
+ src/trio/_tests/test_dtls.py:465: note: def sendto(self, Buffer, Union[tuple[object, ...], str, Buffer], /) -> Coroutine[Any, Any, int]
+ src/trio/_tests/test_dtls.py:465: note: def sendto(self, Buffer, int, Union[tuple[object, ...], str, Buffer], /) -> Coroutine[Any, Any, int]
+ src/trio/_tests/test_dtls.py:497: error: Argument "payload" to "evolve" of "UDPPacket" has incompatible type "bytearray"; expected "bytes" [arg-type]
aiortc (https://github.com/aiortc/aiortc)
+ src/aiortc/codecs/vpx.py:352: error: Argument 1 to "_packetize" of "Vp8Encoder" has incompatible type "bytearray"; expected "bytes" [arg-type]
pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/aglib/kernel/__init__.py: note: In function "load_kconfig":
+ pwndbg/aglib/kernel/__init__.py:130: error: Argument 1 to "Kconfig" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/commands/spray.py: note: In function "spray":
+ pwndbg/commands/spray.py:71: error: Argument 1 to "unpack" of "Arch" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/commands/sigreturn.py: note: In function "sigreturn":
+ pwndbg/commands/sigreturn.py:90: error: Argument 1 to "unpack" of "Arch" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/commands/probeleak.py: note: In function "probeleak":
+ pwndbg/commands/probeleak.py:122: error: Argument 1 to "unpack" of "Arch" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/commands/ptmalloc2.py: note: In function "find_fake_fast":
+ pwndbg/commands/ptmalloc2.py:912: error: Argument 1 to "unpack_size" of "Arch" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/commands/ptmalloc2.py: note: In function "vis_heap_chunks":
+ pwndbg/commands/ptmalloc2.py:1121: error: Argument 1 to "unpack" of "Arch" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/commands/hexdump.py: note: In function "hexdump":
+ pwndbg/commands/hexdump.py:104: error: Argument 1 to "hexdump" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py: note: In function "read_buildversion":
+ pwndbg/aglib/godbg.py:249: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:250: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py: note: In function "get_go_version":
+ pwndbg/aglib/godbg.py:279: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py: note: In function "read_varint_str":
+ pwndbg/aglib/godbg.py:368: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
+ pwndbg/aglib/godbg.py:375: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
+ pwndbg/aglib/godbg.py: note: In function "read_type_name":
+ pwndbg/aglib/godbg.py:389: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:392: error: Incompatible return value type (got "bytearray", expected "bytes") [return-value]
+ pwndbg/aglib/godbg.py: note: In function "_inner_decode_runtime_type":
+ pwndbg/aglib/godbg.py:543: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:625: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:626: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:676: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:681: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:683: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py: note: In member "dump" of class "BasicType":
+ pwndbg/aglib/godbg.py:733: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:736: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:738: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:744: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:756: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:757: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:761: error: Argument 1 to "load_int" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:763: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:768: error: Argument 1 to "load_float" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:771: error: Argument 1 to "load_float" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:772: error: Argument 1 to "load_float" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:781: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:782: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py: note: In member "dump" of class "SliceType":
+ pwndbg/aglib/godbg.py:837: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:838: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:845: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py: note: In member "dump" of class "PointerType":
+ pwndbg/aglib/godbg.py:874: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py: note: In member "dump" of class "MapType":
+ pwndbg/aglib/godbg.py:988: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ pwndbg/aglib/godbg.py:1022: error: Argument 1 to "load_uint" has incompatible type "bytearray"; expected "bytes" [arg-type]
steam.py (https://github.com/Gobot1234/steam.py)
+ steam/app.py:246: error: Argument 1 to "verify_signature" has incompatible type "memoryview[int]"; expected "bytes" [arg-type]
+ steam/state.py:2992: error: Argument 1 to "receive" of "SteamWebSocket" has incompatible type "bytearray"; expected "bytes" [arg-type]
aiohttp (https://github.com/aio-libs/aiohttp)
+ aiohttp/http_writer.py:109:39: error: Argument 1 has incompatible type "bytes | bytearray | memoryview[int]"; expected "bytes" [arg-type]
+ aiohttp/http_writer.py:114:25: error: Incompatible types in assignment (expression has type "memoryview[bytes]", variable has type "bytes | bytearray | memoryview[int]") [assignment]
+ aiohttp/http_writer.py:117:51: error: Argument 1 to "compress" of "ZLibCompressor" has incompatible type "bytes | bytearray | memoryview[int]"; expected "bytes" [arg-type]
+ aiohttp/http_writer.py:134:21: error: Argument 1 to "_writelines" of "StreamWriter" has incompatible type "tuple[bytes, bytes | bytearray | memoryview[int], bytes]"; expected "Iterable[bytes]" [arg-type]
+ aiohttp/_websocket/writer.py:136:23: error: Incompatible types in assignment (expression has type "bytearray", variable has type "bytes") [assignment]
+ aiohttp/_websocket/writer.py:137:34: error: Argument 2 has incompatible type "bytes"; expected "bytearray" [arg-type]
+ aiohttp/web_response.py:584:16: error: Incompatible return value type (got "bytes | bytearray | Payload | None", expected "bytes | Payload | None") [return-value]
+ aiohttp/web_response.py:657:53: error: Incompatible types in assignment (expression has type "bytes | bytearray | Payload | None", variable has type "bytes | Payload | None") [assignment]
+ aiohttp/web_response.py:710:39: error: Argument 1 to "compress" of "ZLibCompressor" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ aiohttp/web_ws.py:605:27: error: Argument 1 of "write" is incompatible with supertype "StreamResponse"; supertype defines the argument type as "bytes | bytearray | memoryview[int]" [override]
+ aiohttp/web_ws.py:605:27: note: This violates the Liskov substitution principle
+ aiohttp/web_ws.py:605:27: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
+ aiohttp/_websocket/reader_py.py:248:25: error: Argument 1 to "decompress_sync" of "ZLibDecompressor" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ aiohttp/_websocket/reader_py.py:312:40: error: Argument "data" to "WSMessagePing" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ aiohttp/_websocket/reader_py.py:316:40: error: Argument "data" to "WSMessagePong" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ aiohttp/_websocket/reader_c.py:248:25: error: Argument 1 to "decompress_sync" of "ZLibDecompressor" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ aiohttp/_websocket/reader_c.py:312:40: error: Argument "data" to "WSMessagePing" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ aiohttp/_websocket/reader_c.py:316:40: error: Argument "data" to "WSMessagePong" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
python-chess (https://github.com/niklasf/python-chess)
+ chess/gaviota.py:1835: error: Incompatible types in assignment (expression has type "bytearray", variable has type "bytes") [assignment]
mitmproxy (https://github.com/mitmproxy/mitmproxy)
+ mitmproxy/dns.py:362: error: Argument 1 to "unpack_from_with_compression" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ mitmproxy/dns.py:396: error: Argument 1 to "decompress_from_record_data" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ mitmproxy/dns.py:399: error: Argument 5 to "ResourceRecord" has incompatible type "bytes | bytearray"; expected "bytes" [arg-type]
+ mitmproxy/proxy/layers/tls.py:565: error: Argument 1 to "dtls_parse_client_hello" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ mitmproxy/proxy/layers/tls.py:567: error: Argument 1 to "parse_client_hello" has incompatible type "bytearray"; expected "bytes" [arg-type]
dulwich (https://github.com/dulwich/dulwich)
+ dulwich/config.py:383: error: Incompatible types in assignment (expression has type "bytearray", variable has type "bytes") [assignment]
werkzeug (https://github.com/pallets/werkzeug)
+ src/werkzeug/sansio/multipart.py:174: error: Argument 1 to "_parse_headers" of "MultipartDecoder" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ src/werkzeug/sansio/multipart.py:213: error: Argument 1 to "_parse_data" of "MultipartDecoder" has incompatible type "bytearray"; expected "bytes" [arg-type]
+ src/werkzeug/sansio/multipart.py:220: error: Argument 1 to "_parse_data" of "MultipartDecoder" has incompatible type "bytearray"; expected "bytes" [arg-type]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mypy v2