Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be strict about arg names in LSP checks #18355

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Dec 29, 2024

Python 3.7 has been dead for a long time, people can use PEP 570
Let's see primer, this will probably need to be a config option

For fixes in mypy's codebase, see #18356

hauntsaninja and others added 2 commits December 28, 2024 17:50
Python 3.7 has been dead for a long time, people can use PEP 570.
Let's see primer, this might need to be an option
hauntsaninja added a commit to hauntsaninja/mypy that referenced this pull request Dec 29, 2024

This comment has been minimized.

cdce8p pushed a commit to cdce8p/mypy that referenced this pull request Dec 29, 2024
cdce8p pushed a commit to cdce8p/mypy that referenced this pull request Dec 29, 2024

This comment has been minimized.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

setuptools (https://github.com/pypa/setuptools)
+ pkg_resources/__init__.py:2156: error: Signature of "_has" incompatible with supertype "NullProvider"  [override]
+ pkg_resources/__init__.py:2156: note:      Superclass:
+ pkg_resources/__init__.py:2156: note:          def _has(self, path: Any) -> bool
+ pkg_resources/__init__.py:2156: note:      Subclass:
+ pkg_resources/__init__.py:2156: note:          def _has(self, fspath: Any) -> bool
+ pkg_resources/__init__.py:2160: error: Signature of "_isdir" incompatible with supertype "NullProvider"  [override]
+ pkg_resources/__init__.py:2160: note:      Superclass:
+ pkg_resources/__init__.py:2160: note:          def _isdir(self, path: Any) -> bool
+ pkg_resources/__init__.py:2160: note:      Subclass:
+ pkg_resources/__init__.py:2160: note:          def _isdir(self, fspath: Any) -> bool
+ setuptools/discovery.py:181: error: Signature of "_looks_like_package" incompatible with supertype "PackageFinder"  [override]
+ setuptools/discovery.py:181: note:      Superclass:
+ setuptools/discovery.py:181: note:          @staticmethod
+ setuptools/discovery.py:181: note:          def _looks_like_package(path: str | PathLike[str], _package_name: str) -> bool
+ setuptools/discovery.py:181: note:      Subclass:
+ setuptools/discovery.py:181: note:          @staticmethod
+ setuptools/discovery.py:181: note:          def _looks_like_package(_path: str | PathLike[str], _package_name: str) -> bool
+ setuptools/discovery.py:256: error: Signature of "_looks_like_package" incompatible with supertype "PEP420PackageFinder"  [override]
+ setuptools/discovery.py:256: note:      Superclass:
+ setuptools/discovery.py:256: note:          @staticmethod
+ setuptools/discovery.py:256: note:          def _looks_like_package(_path: str | PathLike[str], _package_name: str) -> bool
+ setuptools/discovery.py:256: note:      Subclass:
+ setuptools/discovery.py:256: note:          @staticmethod
+ setuptools/discovery.py:256: note:          def _looks_like_package(_path: str | PathLike[str], package_name: str) -> bool
+ setuptools/discovery.py:256: error: Signature of "_looks_like_package" incompatible with supertype "PackageFinder"  [override]
+ setuptools/discovery.py:256: note:      Superclass:
+ setuptools/discovery.py:256: note:          @staticmethod
+ setuptools/discovery.py:256: note:          def _looks_like_package(path: str | PathLike[str], _package_name: str) -> bool
+ setuptools/discovery.py:256: note:      Subclass:
+ setuptools/discovery.py:256: note:          @staticmethod
+ setuptools/discovery.py:256: note:          def _looks_like_package(_path: str | PathLike[str], package_name: str) -> bool

cwltool (https://github.com/common-workflow-language/cwltool)
+ note: In module imported here,
+ cwltool/cwlprov/writablebagfile.py:17: note: ... from here:
+ mypy-stubs/rdflib/graph.pyi: note: In member "add" of class "ConjunctiveGraph":
+ mypy-stubs/rdflib/graph.pyi:222:5: error: Signature of "add" incompatible with supertype "Graph"  [override]
+ mypy-stubs/rdflib/graph.pyi:222:5: note:      Superclass:
+ mypy-stubs/rdflib/graph.pyi:222:5: note:          def add(self, triple: Any) -> None
+ mypy-stubs/rdflib/graph.pyi:222:5: note:      Subclass:
+ mypy-stubs/rdflib/graph.pyi:222:5: note:          def add(self, triple_or_quad: Any) -> None
+ mypy-stubs/rdflib/graph.pyi: note: In member "remove" of class "ConjunctiveGraph":
+ mypy-stubs/rdflib/graph.pyi:224:5: error: Signature of "remove" incompatible with supertype "Graph"  [override]
+ mypy-stubs/rdflib/graph.pyi:224:5: note:      Superclass:
+ mypy-stubs/rdflib/graph.pyi:224:5: note:          def remove(self, triple: Any) -> None
+ mypy-stubs/rdflib/graph.pyi:224:5: note:      Subclass:
+ mypy-stubs/rdflib/graph.pyi:224:5: note:          def remove(self, triple_or_quad: Any) -> None
+ cwltool/job.py: note: In member "_preserve_environment_on_containers_warning" of class "ContainerCommandLineJob":
+ cwltool/job.py:646:5: error: Signature of "_preserve_environment_on_containers_warning" incompatible with supertype "JobBase"  [override]
+ cwltool/job.py:646:5: note:      Superclass:
+ cwltool/job.py:646:5: note:          def _preserve_environment_on_containers_warning(self, varname: Iterable[str] | None = ...) -> None
+ cwltool/job.py:646:5: note:      Subclass:
+ cwltool/job.py:646:5: note:          def _preserve_environment_on_containers_warning(self, varnames: Iterable[str] | None = ...) -> None
+ cwltool/docker.py: note: In member "create_runtime" of class "DockerCommandLineJob":
+ cwltool/docker.py:308:5: error: Signature of "create_runtime" incompatible with supertype "ContainerCommandLineJob"  [override]
+ cwltool/docker.py:308:5: note:      Superclass:
+ cwltool/docker.py:308:5: note:          def create_runtime(self, env: MutableMapping[str, str], runtime_context: RuntimeContext) -> tuple[list[str], str | None]
+ cwltool/docker.py:308:5: note:      Subclass:
+ cwltool/docker.py:308:5: note:          def create_runtime(self, env: MutableMapping[str, str], runtimeContext: RuntimeContext) -> tuple[list[str], str | None]
+ tests/test_fetch.py: note: In member "urljoin" of class "CWLTestFetcher":
+ tests/test_fetch.py:42:5: error: Signature of "urljoin" incompatible with supertype "Fetcher"  [override]
+ tests/test_fetch.py:42:5: note:      Superclass:
+ tests/test_fetch.py:42:5: note:          def urljoin(self, base_url: str, url: str) -> str
+ tests/test_fetch.py:42:5: note:      Subclass:
+ tests/test_fetch.py:42:5: note:          def urljoin(self, base: str, url: str) -> str

altair (https://github.com/vega/altair)
+ altair/expr/core.py:222: error: Signature of "__setattr__" incompatible with supertype "SchemaBase"  [override]
+ altair/expr/core.py:222: note:      Superclass:
+ altair/expr/core.py:222: note:          def __setattr__(self, item: Any, val: Any) -> None
+ altair/expr/core.py:222: note:      Subclass:
+ altair/expr/core.py:222: note:          def __setattr__(self, attr: Any, val: Any) -> None

psycopg (https://github.com/psycopg/psycopg)
+ psycopg/psycopg/types/enum.py:102: error: Signature of "dump" incompatible with supertype "Dumper"  [override]
+ psycopg/psycopg/types/enum.py:102: note:      Superclass:
+ psycopg/psycopg/types/enum.py:102: note:          def dump(self, obj: Any) -> bytes | bytearray | memoryview[int] | None
+ psycopg/psycopg/types/enum.py:102: note:      Subclass:
+ psycopg/psycopg/types/enum.py:102: note:          def dump(self, value: E) -> bytes | bytearray | memoryview[int] | None
+ psycopg/psycopg/types/enum.py:102: note:      Superclass:
+ psycopg/psycopg/types/enum.py:102: note:          def dump(self, obj: Any) -> bytes | bytearray | memoryview[int] | None
+ psycopg/psycopg/types/enum.py:102: note:      Subclass:
+ psycopg/psycopg/types/enum.py:102: note:          def dump(self, value: E) -> bytes | bytearray | memoryview[int] | None
+ psycopg/psycopg/types/enum.py:115: error: Signature of "dump" incompatible with supertype "Dumper"  [override]
+ psycopg/psycopg/types/enum.py:115: note:      Superclass:
+ psycopg/psycopg/types/enum.py:115: note:          def dump(self, obj: Any) -> bytes | bytearray | memoryview[int] | None
+ psycopg/psycopg/types/enum.py:115: note:      Subclass:
+ psycopg/psycopg/types/enum.py:115: note:          def [E: Enum] dump(self, value: E) -> bytes | bytearray | memoryview[int] | None
+ psycopg/psycopg/types/enum.py:115: note:      Superclass:
+ psycopg/psycopg/types/enum.py:115: note:          def dump(self, obj: Any) -> bytes | bytearray | memoryview[int] | None
+ psycopg/psycopg/types/enum.py:115: note:      Subclass:
+ psycopg/psycopg/types/enum.py:115: note:          def [E: Enum] dump(self, value: E) -> bytes | bytearray | memoryview[int] | None

operator (https://github.com/canonical/operator)
+ ops/framework.py:1383: error: Signature of "add" incompatible with supertype "MutableSet"  [override]
+ ops/framework.py:1383: note:      Superclass:
+ ops/framework.py:1383: note:          def add(self, value: Any) -> None
+ ops/framework.py:1383: note:      Subclass:
+ ops/framework.py:1383: note:          def add(self, key: Any) -> Any
+ ops/framework.py:1391: error: Signature of "discard" incompatible with supertype "MutableSet"  [override]
+ ops/framework.py:1391: note:      Superclass:
+ ops/framework.py:1391: note:          def discard(self, value: Any) -> None
+ ops/framework.py:1391: note:      Subclass:
+ ops/framework.py:1391: note:          def discard(self, key: Any) -> Any

prefect (https://github.com/PrefectHQ/prefect)
+ src/prefect/events/worker.py:74: error: Signature of "_prepare_item" incompatible with supertype "QueueService"  [override]
+ src/prefect/events/worker.py:74: note:      Superclass:
+ src/prefect/events/worker.py:74: note:          def _prepare_item(self, item: Event) -> Event
+ src/prefect/events/worker.py:74: note:      Subclass:
+ src/prefect/events/worker.py:74: note:          def _prepare_item(self, event: Event) -> Event
+ src/prefect/events/worker.py:78: error: Signature of "_handle" incompatible with supertype "QueueService"  [override]
+ src/prefect/events/worker.py:78: note:      Superclass:
+ src/prefect/events/worker.py:78: note:          def _handle(self, item: Event) -> Coroutine[Any, Any, None]
+ src/prefect/events/worker.py:78: note:      Subclass:
+ src/prefect/events/worker.py:78: note:          def _handle(self, event: Event) -> Coroutine[Any, Any, Any]
+ src/prefect/events/worker.py:78: error: Signature of "_handle" incompatible with supertype "_QueueServiceBase"  [override]
+ src/prefect/events/worker.py:78: note:      Superclass:
+ src/prefect/events/worker.py:78: note:          def _handle(self, item: Any) -> Coroutine[Any, Any, Any]
+ src/prefect/events/worker.py:78: note:      Subclass:
+ src/prefect/events/worker.py:78: note:          def _handle(self, event: Event) -> Coroutine[Any, Any, Any]
+ src/prefect/server/orchestration/core_policy.py:202: error: Signature of "before_transition" incompatible with supertype "BaseOrchestrationRule"  [override]
+ src/prefect/server/orchestration/core_policy.py:202: note:      Superclass:
+ src/prefect/server/orchestration/core_policy.py:202: note:          def before_transition(self, initial_state: State | None, proposed_state: State | None, context: OrchestrationContext) -> Coroutine[Any, Any, None]
+ src/prefect/server/orchestration/core_policy.py:202: note:      Subclass:
+ src/prefect/server/orchestration/core_policy.py:202: note:          def before_transition(self, initial_state: State | None, validated_state: State | None, context: TaskOrchestrationContext) -> Coroutine[Any, Any, None]

pandas (https://github.com/pandas-dev/pandas)
+ pandas/_libs/sparse.pyi:43: error: Signature of "intersect" incompatible with supertype "SparseIndex"  [override]
+ pandas/_libs/sparse.pyi:43: note:      Superclass:
+ pandas/_libs/sparse.pyi:43: note:          def intersect(self, y_: SparseIndex) -> BlockIndex
+ pandas/_libs/sparse.pyi:43: note:      Subclass:
+ pandas/_libs/sparse.pyi:43: note:          def intersect(self, other: SparseIndex) -> BlockIndex
+ pandas/_libs/sparse.pyi:44: error: Signature of "make_union" incompatible with supertype "SparseIndex"  [override]
+ pandas/_libs/sparse.pyi:44: note:      Superclass:
+ pandas/_libs/sparse.pyi:44: note:          def make_union(self, y_: SparseIndex) -> BlockIndex
+ pandas/_libs/sparse.pyi:44: note:      Subclass:
+ pandas/_libs/sparse.pyi:44: note:          def make_union(self, y: SparseIndex) -> BlockIndex
+ pandas/core/arrays/timedeltas.py:228: error: Signature of "_from_sequence" incompatible with supertype "ExtensionArray"  [override]
+ pandas/core/arrays/timedeltas.py:228: note:      Superclass:
+ pandas/core/arrays/timedeltas.py:228: note:          @classmethod
+ pandas/core/arrays/timedeltas.py:228: note:          def _from_sequence(cls, scalars: Any, *, dtype: ExtensionDtype | str | dtype[Any] | type[str] | type[complex] | type[bool] | type[object] | None = ..., copy: bool = ...) -> TimedeltaArray
+ pandas/core/arrays/timedeltas.py:228: note:      Subclass:
+ pandas/core/arrays/timedeltas.py:228: note:          @classmethod
+ pandas/core/arrays/timedeltas.py:228: note:          def _from_sequence(cls, data: Any, *, dtype: Any = ..., copy: bool = ...) -> TimedeltaArray
+ pandas/core/arrays/masked.py:920: error: Signature of "take" incompatible with supertype "ExtensionArray"  [override]
+ pandas/core/arrays/masked.py:920: note:      Superclass:
+ pandas/core/arrays/masked.py:920: note:          def take(self, indices: Sequence[int] | Sequence[integer[Any]] | ndarray[tuple[int, ...], dtype[integer[Any]]], *, allow_fill: bool = ..., fill_value: Any = ...) -> BaseMaskedArray
+ pandas/core/arrays/masked.py:920: note:      Subclass:
+ pandas/core/arrays/masked.py:920: note:          def take(self, indexer: Any, *, allow_fill: bool = ..., fill_value: str | float | bool | Period | Timestamp | Timedelta | Interval[Any] | datetime64[date | int | None] | timedelta64[timedelta | int | None] | date | None = ..., axis: int = ...) -> BaseMaskedArray
+ pandas/core/arrays/numeric.py:276: error: Signature of "_coerce_to_array" incompatible with supertype "BaseMaskedArray"  [override]
+ pandas/core/arrays/numeric.py:276: note:      Superclass:
+ pandas/core/arrays/numeric.py:276: note:          @classmethod
+ pandas/core/arrays/numeric.py:276: note:          def _coerce_to_array(cls, values: Any, *, dtype: dtype[Any] | ExtensionDtype, copy: bool = ...) -> tuple[ndarray[Any, Any], ndarray[Any, Any]]
+ pandas/core/arrays/numeric.py:276: note:      Subclass:
+ pandas/core/arrays/numeric.py:276: note:          @classmethod
+ pandas/core/arrays/numeric.py:276: note:          def _coerce_to_array(cls, value: Any, *, dtype: dtype[Any] | ExtensionDtype, copy: bool = ...) -> tuple[ndarray[Any, Any], ndarray[Any, Any]]
+ pandas/core/arrays/boolean.py:365: error: Signature of "_coerce_to_array" incompatible with supertype "BaseMaskedArray"  [override]
+ pandas/core/arrays/boolean.py:365: note:      Superclass:
+ pandas/core/arrays/boolean.py:365: note:          @classmethod
+ pandas/core/arrays/boolean.py:365: note:          def _coerce_to_array(cls, values: Any, *, dtype: dtype[Any] | ExtensionDtype, copy: bool = ...) -> tuple[ndarray[Any, Any], ndarray[Any, Any]]
+ pandas/core/arrays/boolean.py:365: note:      Subclass:
+ pandas/core/arrays/boolean.py:365: note:          @classmethod
+ pandas/core/arrays/boolean.py:365: note:          def _coerce_to_array(cls, value: Any, *, dtype: dtype[Any] | ExtensionDtype, copy: bool = ...) -> tuple[ndarray[Any, Any], ndarray[Any, Any]]
+ pandas/core/arrays/sparse/array.py:1161: error: Signature of "searchsorted" incompatible with supertype "ExtensionArray"  [override]
+ pandas/core/arrays/sparse/array.py:1161: note:      Superclass:
+ pandas/core/arrays/sparse/array.py:1161: note:          def searchsorted(self, value: int | float | complex | str | bytes | generic[Any] | _SupportsArray[dtype[Any]] | _NestedSequence[_SupportsArray[dtype[Any]]] | bool | int | float | complex | str | bytes | _NestedSequence[bool | int | float | complex | str | bytes] | ExtensionArray, side: Literal['left', 'right'] = ..., sorter: Any | None | None = ...) -> ndarray[tuple[int, ...], dtype[signedinteger[_32Bit | _64Bit]]] | signedinteger[_32Bit | _64Bit]
+ pandas/core/arrays/sparse/array.py:1161: note:      Subclass:
+ pandas/core/arrays/sparse/array.py:1161: note:          def searchsorted(self, v: ExtensionArray | ndarray[Any, Any] | object, side: Literal['left', 'right'] = ..., sorter: Any | None | None = ...) -> ndarray[tuple[int, ...], dtype[signedinteger[_32Bit | _64Bit]]] | signedinteger[_32Bit | _64Bit]
+ pandas/io/excel/_openpyxl.py:608: error: Signature of "get_sheet_data" incompatible with supertype "BaseExcelReader"  [override]
+ pandas/io/excel/_openpyxl.py:608: note:      Superclass:
+ pandas/io/excel/_openpyxl.py:608: note:          def get_sheet_data(self, sheet: Any, rows: int | None = ...) -> Any
+ pandas/io/excel/_openpyxl.py:608: note:      Subclass:
+ pandas/io/excel/_openpyxl.py:608: note:          def get_sheet_data(self, sheet: Any, file_rows_needed: int | None = ...) -> list[list[str | float | bool | Period | Timestamp | Timedelta | Interval[Any] | datetime64[date | int | None] | timedelta64[timedelta | int | None] | date]]
+ pandas/core/indexes/range.py:1058: error: Signature of "_concat" incompatible with supertype "Index"  [override]
+ pandas/core/indexes/range.py:1058: note:      Superclass:
+ pandas/core/indexes/range.py:1058: note:          def _concat(self, to_concat: list[Index], name: Hashable) -> Index
+ pandas/core/indexes/range.py:1058: note:      Subclass:
+ pandas/core/indexes/range.py:1058: note:          def _concat(self, indexes: list[Index], name: Hashable) -> Index
+ pandas/core/indexes/multi.py:1589: error: Signature of "_set_names" incompatible with supertype "Index"  [override]
+ pandas/core/indexes/multi.py:1589: note:      Superclass:
+ pandas/core/indexes/multi.py:1589: note:          def _set_names(self, values: Any, *, level: Any = ...) -> None
+ pandas/core/indexes/multi.py:1589: note:      Subclass:
+ pandas/core/indexes/multi.py:1589: note:          def _set_names(self, names: Any, *, level: Any = ...) -> None
+ pandas/core/indexes/category.py:431: error: Signature of "_maybe_cast_listlike_indexer" incompatible with supertype "Index"  [override]
+ pandas/core/indexes/category.py:431: note:      Superclass:
+ pandas/core/indexes/category.py:431: note:          def _maybe_cast_listlike_indexer(self, target: Any) -> Index
+ pandas/core/indexes/category.py:431: note:      Subclass:
+ pandas/core/indexes/category.py:431: note:          def _maybe_cast_listlike_indexer(self, values: Any) -> CategoricalIndex
+ pandas/core/resample.py:1688: error: Signature of "_upsample" incompatible with supertype "Resampler"  [override]
+ pandas/core/resample.py:1688: note:      Superclass:
+ pandas/core/resample.py:1688: note:          def _upsample(self, f: Any, limit: int | None = ..., fill_value: Any = ...) -> Any
+ pandas/core/resample.py:1688: note:      Subclass:
+ pandas/core/resample.py:1688: note:          def _upsample(self, method: Any, limit: int | None = ..., fill_value: Any = ...) -> Any
+ pandas/core/resample.py:1833: error: Signature of "_upsample" incompatible with supertype "Resampler"  [override]
+ pandas/core/resample.py:1833: note:      Superclass:
+ pandas/core/resample.py:1833: note:          def _upsample(self, f: Any, limit: int | None = ..., fill_value: Any = ...) -> Any
+ pandas/core/resample.py:1833: note:      Subclass:
+ pandas/core/resample.py:1833: note:          def _upsample(self, method: Any, limit: int | None = ..., fill_value: Any = ...) -> Any
+ pandas/io/excel/_xlrd.py:79: error: Signature of "get_sheet_data" incompatible with supertype "BaseExcelReader"  [override]
+ pandas/io/excel/_xlrd.py:79: note:      Superclass:
+ pandas/io/excel/_xlrd.py:79: note:          def get_sheet_data(self, sheet: Any, rows: int | None = ...) -> Any
+ pandas/io/excel/_xlrd.py:79: note:      Subclass:
+ pandas/io/excel/_xlrd.py:79: note:          def get_sheet_data(self, sheet: Any, file_rows_needed: int | None = ...) -> list[list[str | float | bool | Period | Timestamp | Timedelta | Interval[Any] | datetime64[date | int | None] | timedelta64[timedelta | int | None] | date]]
+ pandas/io/excel/_pyxlsb.py:97: error: Signature of "get_sheet_data" incompatible with supertype "BaseExcelReader"  [override]
+ pandas/io/excel/_pyxlsb.py:97: note:      Superclass:
+ pandas/io/excel/_pyxlsb.py:97: note:          def get_sheet_data(self, sheet: Any, rows: int | None = ...) -> Any
+ pandas/io/excel/_pyxlsb.py:97: note:      Subclass:
+ pandas/io/excel/_pyxlsb.py:97: note:          def get_sheet_data(self, sheet: Any, file_rows_needed: int | None = ...) -> list[list[str | float | bool | Period | Timestamp | Timedelta | Interval[Any] | datetime64[date | int | None] | timedelta64[timedelta | int | None] | date]]
+ pandas/io/excel/_odfreader.py:102: error: Signature of "get_sheet_data" incompatible with supertype "BaseExcelReader"  [override]
+ pandas/io/excel/_odfreader.py:102: note:      Superclass:
+ pandas/io/excel/_odfreader.py:102: note:          def get_sheet_data(self, sheet: Any, rows: int | None = ...) -> Any
+ pandas/io/excel/_odfreader.py:102: note:      Subclass:
+ pandas/io/excel/_odfreader.py:102: note:          def get_sheet_data(self, sheet: Any, file_rows_needed: int | None = ...) -> list[list[str | float | bool | Period | Timestamp | Timedelta | Interval[Any] | datetime64[date | int | None] | timedelta64[timedelta | int | None] | date | NaTType]]
+ pandas/io/excel/_calamine.py:100: error: Signature of "get_sheet_data" incompatible with supertype "BaseExcelReader"  [override]
+ pandas/io/excel/_calamine.py:100: note:      Superclass:
+ pandas/io/excel/_calamine.py:100: note:          def get_sheet_data(self, sheet: Any, rows: int | None = ...) -> Any
+ pandas/io/excel/_calamine.py:100: note:      Subclass:
+ pandas/io/excel/_calamine.py:100: note:          def get_sheet_data(self, sheet: Any, file_rows_needed: int | None = ...) -> list[list[str | float | bool | Period | Timestamp | Timedelta | Interval[Any] | datetime64[date | int | None] | timedelta64[timedelta | int | None] | date | NaTType | time]]
+ pandas/tests/extension/test_sparse.py:100: error: Signature of "_supports_reduction" incompatible with supertype "BaseReduceTests"  [override]
+ pandas/tests/extension/test_sparse.py:100: note:      Superclass:
+ pandas/tests/extension/test_sparse.py:100: note:          def _supports_reduction(self, ser: Series, op_name: str) -> bool
+ pandas/tests/extension/test_sparse.py:100: note:      Subclass:
+ pandas/tests/extension/test_sparse.py:100: note:          def _supports_reduction(self, obj: Any, op_name: str) -> bool
+ pandas/tests/extension/test_sparse.py:419: error: Signature of "_compare_other" incompatible with supertype "BaseComparisonOpsTests"  [override]
+ pandas/tests/extension/test_sparse.py:419: note:      Superclass:
+ pandas/tests/extension/test_sparse.py:419: note:          def _compare_other(self, ser: Series, data: Any, op: Any, other: Any) -> Any
+ pandas/tests/extension/test_sparse.py:419: note:      Subclass:
+ pandas/tests/extension/test_sparse.py:419: note:          def _compare_other(self, ser: Series, data_for_compare: SparseArray, comparison_op: Any, other: Any) -> Any
+ pandas/tests/extension/test_period.py:84: error: Signature of "_supports_reduction" incompatible with supertype "BaseReduceTests"  [override]
+ pandas/tests/extension/test_period.py:84: note:      Superclass:
+ pandas/tests/extension/test_period.py:84: note:          def _supports_reduction(self, ser: Series, op_name: str) -> bool
+ pandas/tests/extension/test_period.py:84: note:      Subclass:
+ pandas/tests/extension/test_period.py:84: note:          def _supports_reduction(self, obj: Any, op_name: str) -> bool
+ pandas/tests/extension/test_datetime.py:106: error: Signature of "_supports_reduction" incompatible with supertype "BaseReduceTests"  [override]
+ pandas/tests/extension/test_datetime.py:106: note:      Superclass:
+ pandas/tests/extension/test_datetime.py:106: note:          def _supports_reduction(self, ser: Series, op_name: str) -> bool
+ pandas/tests/extension/test_datetime.py:106: note:      Subclass:
+ pandas/tests/extension/test_datetime.py:106: note:          def _supports_reduction(self, obj: Any, op_name: str) -> bool

bidict (https://github.com/jab/bidict)
+ bidict/_bidict.py: note: In member "pop" of class "MutableBidict":
+ bidict/_bidict.py:121:6: error: Signature of "pop" incompatible with supertype "MutableMapping"  [override]
+ bidict/_bidict.py:121:6: note:      Superclass:
+ bidict/_bidict.py:121:6: note:          @overload
+ bidict/_bidict.py:121:6: note:          def pop(self, KT, /) -> VT
+ bidict/_bidict.py:121:6: note:          @overload
+ bidict/_bidict.py:121:6: note:          def pop(self, KT, /, default: VT) -> VT
+ bidict/_bidict.py:121:6: note:          @overload
+ bidict/_bidict.py:121:6: note:          def [_T] pop(self, KT, /, default: _T) -> VT | _T
+ bidict/_bidict.py:121:6: note:      Subclass:
+ bidict/_bidict.py:121:6: note:          @overload
+ bidict/_bidict.py:121:6: note:          def pop(self, KT, /) -> VT
+ bidict/_bidict.py:121:6: note:          @overload
+ bidict/_bidict.py:121:6: note:          def [DT] pop(self, KT, DT = ..., /) -> VT | DT

pip (https://github.com/pypa/pip)
+ src/pip/_internal/vcs/mercurial.py:105: error: Signature of "get_requirement_revision" incompatible with supertype "VersionControl"  [override]
+ src/pip/_internal/vcs/mercurial.py:105: note:      Superclass:
+ src/pip/_internal/vcs/mercurial.py:105: note:          @classmethod
+ src/pip/_internal/vcs/mercurial.py:105: note:          def get_requirement_revision(cls, repo_dir: str) -> str
+ src/pip/_internal/vcs/mercurial.py:105: note:      Subclass:
+ src/pip/_internal/vcs/mercurial.py:105: note:          @classmethod
+ src/pip/_internal/vcs/mercurial.py:105: note:          def get_requirement_revision(cls, location: str) -> str
+ src/pip/_internal/vcs/git.py:522: error: Signature of "should_add_vcs_url_prefix" incompatible with supertype "VersionControl"  [override]
+ src/pip/_internal/vcs/git.py:522: note:      Superclass:
+ src/pip/_internal/vcs/git.py:522: note:          @classmethod
+ src/pip/_internal/vcs/git.py:522: note:          def should_add_vcs_url_prefix(cls, remote_url: str) -> bool
+ src/pip/_internal/vcs/git.py:522: note:      Subclass:
+ src/pip/_internal/vcs/git.py:522: note:          @staticmethod
+ src/pip/_internal/vcs/git.py:522: note:          def should_add_vcs_url_prefix(repo_url: str) -> bool

sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/util/docfields.py: note: In member "make_field" of class "GroupedField":
+ sphinx/util/docfields.py:211:5: error: Signature of "make_field" incompatible with supertype "Field"  [override]
+ sphinx/util/docfields.py:211:5: note:      Superclass:
+ sphinx/util/docfields.py:211:5: note:          def make_field(self, types: dict[str, list[Node]], domain: str, item: tuple[Any, ...], env: BuildEnvironment | None = ..., inliner: Inliner | None = ..., location: Element | None = ...) -> field
+ sphinx/util/docfields.py:211:5: note:      Subclass:
+ sphinx/util/docfields.py:211:5: note:          def make_field(self, types: dict[str, list[Node]], domain: str, items: tuple[Any, ...], env: BuildEnvironment | None = ..., inliner: Inliner | None = ..., location: Element | None = ...) -> field
+ sphinx/util/docfields.py: note: In member "make_field" of class "TypedField":
+ sphinx/util/docfields.py:284:5: error: Signature of "make_field" incompatible with supertype "Field"  [override]
+ sphinx/util/docfields.py:284:5: note:      Superclass:
+ sphinx/util/docfields.py:284:5: note:          def make_field(self, types: dict[str, list[Node]], domain: str, item: tuple[Any, ...], env: BuildEnvironment | None = ..., inliner: Inliner | None = ..., location: Element | None = ...) -> field
+ sphinx/util/docfields.py:284:5: note:      Subclass:
+ sphinx/util/docfields.py:284:5: note:          def make_field(self, types: dict[str, list[Node]], domain: str, items: tuple[Any, ...], env: BuildEnvironment | None = ..., inliner: Inliner | None = ..., location: Element | None = ...) -> field
+ sphinx/domains/python/_object.py: note: In member "add_target_and_index" of class "PyObject":
+ sphinx/domains/python/_object.py:332:5: error: Signature of "add_target_and_index" incompatible with supertype "ObjectDescription"  [override]
+ sphinx/domains/python/_object.py:332:5: note:      Superclass:
+ sphinx/domains/python/_object.py:332:5: note:          def add_target_and_index(self, name: tuple[str, str], sig: str, signode: desc_signature) -> None
+ sphinx/domains/python/_object.py:332:5: note:      Subclass:
+ sphinx/domains/python/_object.py:332:5: note:          def add_target_and_index(self, name_cls: tuple[str, str], sig: str, signode: desc_signature) -> None
+ sphinx/domains/python/__init__.py: note: In member "add_target_and_index" of class "PyFunction":
+ sphinx/domains/python/__init__.py:98:5: error: Signature of "add_target_and_index" incompatible with supertype "ObjectDescription"  [override]
+ sphinx/domains/python/__init__.py:98:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:98:5: note:          def add_target_and_index(self, name: tuple[str, str], sig: str, signode: desc_signature) -> None
+ sphinx/domains/python/__init__.py:98:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:98:5: note:          def add_target_and_index(self, name_cls: tuple[str, str], sig: str, signode: desc_signature) -> None
+ sphinx/domains/python/__init__.py: note: In member "get_index_text" of class "PyFunction":
+ sphinx/domains/python/__init__.py:113:5: error: Signature of "get_index_text" incompatible with supertype "PyObject"  [override]
+ sphinx/domains/python/__init__.py:113:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:113:5: note:          def get_index_text(self, modname: str, name: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py:113:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:113:5: note:          def get_index_text(self, modname: str, name_cls: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py: note: In member "get_index_text" of class "PyVariable":
+ sphinx/domains/python/__init__.py:164:5: error: Signature of "get_index_text" incompatible with supertype "PyObject"  [override]
+ sphinx/domains/python/__init__.py:164:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:164:5: note:          def get_index_text(self, modname: str, name: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py:164:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:164:5: note:          def get_index_text(self, modname: str, name_cls: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py: note: In member "get_index_text" of class "PyClasslike":
+ sphinx/domains/python/__init__.py:191:5: error: Signature of "get_index_text" incompatible with supertype "PyObject"  [override]
+ sphinx/domains/python/__init__.py:191:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:191:5: note:          def get_index_text(self, modname: str, name: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py:191:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:191:5: note:          def get_index_text(self, modname: str, name_cls: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py: note: In member "get_index_text" of class "PyMethod":
+ sphinx/domains/python/__init__.py:236:5: error: Signature of "get_index_text" incompatible with supertype "PyObject"  [override]
+ sphinx/domains/python/__init__.py:236:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:236:5: note:          def get_index_text(self, modname: str, name: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py:236:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:236:5: note:          def get_index_text(self, modname: str, name_cls: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py: note: In member "get_index_text" of class "PyAttribute":
+ sphinx/domains/python/__init__.py:326:5: error: Signature of "get_index_text" incompatible with supertype "PyObject"  [override]
+ sphinx/domains/python/__init__.py:326:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:326:5: note:          def get_index_text(self, modname: str, name: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py:326:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:326:5: note:          def get_index_text(self, modname: str, name_cls: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py: note: In member "get_index_text" of class "PyProperty":
+ sphinx/domains/python/__init__.py:377:5: error: Signature of "get_index_text" incompatible with supertype "PyObject"  [override]
+ sphinx/domains/python/__init__.py:377:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:377:5: note:          def get_index_text(self, modname: str, name: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py:377:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:377:5: note:          def get_index_text(self, modname: str, name_cls: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py: note: In member "get_index_text" of class "PyTypeAlias":
+ sphinx/domains/python/__init__.py:416:5: error: Signature of "get_index_text" incompatible with supertype "PyObject"  [override]
+ sphinx/domains/python/__init__.py:416:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:416:5: note:          def get_index_text(self, modname: str, name: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py:416:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:416:5: note:          def get_index_text(self, modname: str, name_cls: tuple[str, str]) -> str
+ sphinx/domains/python/__init__.py: note: In member "resolve_xref" of class "PythonDomain":
+ sphinx/domains/python/__init__.py:829:5: error: Signature of "resolve_xref" incompatible with supertype "Domain"  [override]
+ sphinx/domains/python/__init__.py:829:5: note:      Superclass:
+ sphinx/domains/python/__init__.py:829:5: note:          def resolve_xref(self, env: BuildEnvironment, fromdocname: str, builder: Builder, typ: str, target: str, node: pending_xref, contnode: Element) -> reference | None
+ sphinx/domains/python/__init__.py:829:5: note:      Subclass:
+ sphinx/domains/python/__init__.py:829:5: note:          def resolve_xref(self, env: BuildEnvironment, fromdocname: str, builder: Builder, type: str, target: str, node: pending_xref, contnode: Element) -> reference | None
+ sphinx/domains/javascript.py: note: In member "add_target_and_index" of class "JSObject":
+ sphinx/domains/javascript.py:145:5: error: Signature of "add_target_and_index" incompatible with supertype "ObjectDescription"  [override]
+ sphinx/domains/javascript.py:145:5: note:      Superclass:
+ sphinx/domains/javascript.py:145:5: note:          def add_target_and_index(self, name: tuple[str, str], sig: str, signode: desc_signature) -> None
+ sphinx/domains/javascript.py:145:5: note:      Subclass:
+ sphinx/domains/javascript.py:145:5: note:          def add_target_and_index(self, name_obj: tuple[str, str], sig: str, signode: desc_signature) -> None
+ sphinx/domains/std/__init__.py: note: In member "handle_signature" of class "ConfigurationValue":
+ sphinx/domains/std/__init__.py:122:5: error: Signature of "handle_signature" incompatible with supertype "ObjectDescription"  [override]
+ sphinx/domains/std/__init__.py:122:5: note:      Superclass:
+ sphinx/domains/std/__init__.py:122:5: note:          def handle_signature(self, sig: str, signode: desc_signature) -> str
+ sphinx/domains/std/__init__.py:122:5: note:      Subclass:
+ sphinx/domains/std/__init__.py:122:5: note:          def handle_signature(self, sig: str, sig_node: desc_signature) -> str
+ sphinx/domains/std/__init__.py: note: In member "add_target_and_index" of class "Cmdoption":
+ sphinx/domains/std/__init__.py:285:5: error: Signature of "add_target_and_index" incompatible with supertype "ObjectDescription"  [override]
+ sphinx/domains/std/__init__.py:285:5: note:      Superclass:
+ sphinx/domains/std/__init__.py:285:5: note:          def add_target_and_index(self, name: str, sig: str, signode: desc_signature) -> None
+ sphinx/domains/std/__init__.py:285:5: note:      Subclass:
+ sphinx/domains/std/__init__.py:285:5: note:          def add_target_and_index(self, firstname: str, sig: str, signode: desc_signature) -> None
+ sphinx/domains/cpp/_ast.py: note: In member "describe_signature" of class "ASTTemplateKeyParamPackIdDefault":
+ sphinx/domains/cpp/_ast.py:3769:5: error: Signature of "describe_signature" incompatible with supertype "ASTTemplateParam"  [override]
+ sphinx/domains/cpp/_ast.py:3769:5: note:      Superclass:
+ sphinx/domains/cpp/_ast.py:3769:5: note:          def describe_signature(self, parentNode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/_ast.py:3769:5: note:      Subclass:
+ sphinx/domains/cpp/_ast.py:3769:5: note:          def describe_signature(self, signode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/_ast.py: note: In member "describe_signature" of class "ASTTemplateParamType":
+ sphinx/domains/cpp/_ast.py:3826:5: error: Signature of "describe_signature" incompatible with supertype "ASTTemplateParam"  [override]
+ sphinx/domains/cpp/_ast.py:3826:5: note:      Superclass:
+ sphinx/domains/cpp/_ast.py:3826:5: note:          def describe_signature(self, parentNode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/_ast.py:3826:5: note:      Subclass:
+ sphinx/domains/cpp/_ast.py:3826:5: note:          def describe_signature(self, signode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/_ast.py: note: In member "describe_signature" of class "ASTTemplateParamTemplateType":
+ sphinx/domains/cpp/_ast.py:3876:5: error: Signature of "describe_signature" incompatible with supertype "ASTTemplateParam"  [override]
+ sphinx/domains/cpp/_ast.py:3876:5: note:      Superclass:
+ sphinx/domains/cpp/_ast.py:3876:5: note:          def describe_signature(self, parentNode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/_ast.py:3876:5: note:      Subclass:
+ sphinx/domains/cpp/_ast.py:3876:5: note:          def describe_signature(self, signode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/_ast.py: note: In member "describe_signature" of class "ASTTemplateParamNonType":
+ sphinx/domains/cpp/_ast.py:3943:5: error: Signature of "describe_signature" incompatible with supertype "ASTTemplateParam"  [override]
+ sphinx/domains/cpp/_ast.py:3943:5: note:      Superclass:
+ sphinx/domains/cpp/_ast.py:3943:5: note:          def describe_signature(self, parentNode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/_ast.py:3943:5: note:      Subclass:
+ sphinx/domains/cpp/_ast.py:3943:5: note:          def describe_signature(self, signode: TextElement, mode: str, env: BuildEnvironment, symbol: Symbol) -> None
+ sphinx/domains/cpp/__init__.py: note: In member "add_target_and_index" of class "CPPObject":
+ sphinx/domains/cpp/__init__.py:212:5: error: Signature of "add_target_and_index" incompatible with supertype "ObjectDescription"  [override]
+ sphinx/domains/cpp/__init__.py:212:5: note:      Superclass:
+ sphinx/domains/cpp/__init__.py:212:5: note:          def add_target_and_index(self, name: ASTDeclaration, sig: str, signode: desc_signature) -> None
+ sphinx/domains/cpp/__init__.py:212:5: note:      Subclass:
+ sphinx/domains/cpp/__init__.py:212:5: note:          def add_target_and_index(self, ast: ASTDeclaration, sig: str, signode: TextElement) -> None
+ sphinx/domains/c/__init__.py: note: In member "add_target_and_index" of class "CObject":
+ sphinx/domains/c/__init__.py:158:5: error: Signature of "add_target_and_index" incompatible with supertype "ObjectDescription"  [override]
+ sphinx/domains/c/__init__.py:158:5: note:      Superclass:
+ sphinx/domains/c/__init__.py:158:5: note:          def add_target_and_index(self, name: ASTDeclaration, sig: str, signode: desc_signature) -> None
+ sphinx/domains/c/__init__.py:158:5: note:      Subclass:
+ sphinx/domains/c/__init__.py:158:5: note:          def add_target_and_index(self, ast: ASTDeclaration, sig: str, signode: TextElement) -> None
+ sphinx/jinja2glue.py: note: In member "render_string" of class "BuiltinTemplateLoader":
+ sphinx/jinja2glue.py:217:5: error: Signature of "render_string" incompatible with supertype "TemplateBridge"  [override]
+ sphinx/jinja2glue.py:217:5: note:      Superclass:
+ sphinx/jinja2glue.py:217:5: note:          def render_string(self, template: str, context: dict[Any, Any]) -> str
+ sphinx/jinja2glue.py:217:5: note:      Subclass:
+ sphinx/jinja2glue.py:217:5: note:          def render_string(self, source: str, context: dict[str, Any]) -> str
+ sphinx/builders/gettext.py: note: In member "render" of class "GettextRenderer":
+ sphinx/builders/gettext.py:119:5: error: Signature of "render" incompatible with supertype "BaseRenderer"  [override]
+ sphinx/builders/gettext.py:119:5: note:      Superclass:
+ sphinx/builders/gettext.py:119:5: note:          def render(self, template_name: str, context: dict[str, Any]) -> str
+ sphinx/builders/gettext.py:119:5: note:      Subclass:
+ sphinx/builders/gettext.py:119:5: note:          def render(self, filename: str, context: dict[str, Any]) -> str
+ sphinx/builders/latex/__init__.py: note: In member "write_documents" of class "LaTeXBuilder":
+ sphinx/builders/latex/__init__.py:301:5: error: Signature of "write_documents" incompatible with supertype "Builder"  [override]
+ sphinx/builders/latex/__init__.py:301:5: note:      Superclass:
+ sphinx/builders/latex/__init__.py:301:5: note:          def write_documents(self, docnames: AbstractSet[str]) -> None
+ sphinx/builders/latex/__init__.py:301:5: note:      Subclass:
+ sphinx/builders/latex/__init__.py:301:5: note:          def write_documents(self, _docnames: AbstractSet[str]) -> None
+ sphinx/search/zh.py: note: In member "word_filter" of class "SearchChinese":
+ sphinx/search/zh.py:253:5: error: Signature of "word_filter" incompatible with supertype "SearchLanguage"  [override]
+ sphinx/search/zh.py:253:5: note:      Superclass:
+ sphinx/search/zh.py:253:5: note:          def word_filter(self, word: str) -> bool
+ sphinx/search/zh.py:253:5: note:      Subclass:
+ sphinx/search/zh.py:253:5: note:          def word_filter(self, stemmed_word: str) -> bool
+ sphinx/search/ja.py: note: In member "word_filter" of class "SearchJapanese":
+ sphinx/search/ja.py:541:5: error: Signature of "word_filter" incompatible with supertype "SearchLanguage"  [override]
+ sphinx/search/ja.py:541:5: note:      Superclass:
+ sphinx/search/ja.py:541:5: note:          def word_filter(self, word: str) -> bool
+ sphinx/search/ja.py:541:5: note:      Subclass:

... (truncated 37 lines) ...

dd-trace-py (https://github.com/DataDog/dd-trace-py)
+ ddtrace/internal/wrapping/context.py:380: error: Signature of "is_wrapped" incompatible with supertype "BaseWrappingContext"  [override]
+ ddtrace/internal/wrapping/context.py:380: note:      Superclass:
+ ddtrace/internal/wrapping/context.py:380: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:380: note:          def is_wrapped(cls, _f: FunctionType) -> bool
+ ddtrace/internal/wrapping/context.py:380: note:      Subclass:
+ ddtrace/internal/wrapping/context.py:380: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:380: note:          def is_wrapped(cls, f: FunctionType) -> bool
+ ddtrace/internal/wrapping/context.py:387: error: Signature of "extract" incompatible with supertype "BaseWrappingContext"  [override]
+ ddtrace/internal/wrapping/context.py:387: note:      Superclass:
+ ddtrace/internal/wrapping/context.py:387: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:387: note:          def extract(cls, _f: FunctionType) -> BaseWrappingContext
+ ddtrace/internal/wrapping/context.py:387: note:      Subclass:
+ ddtrace/internal/wrapping/context.py:387: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:387: note:          def extract(cls, f: FunctionType) -> WrappingContext
+ ddtrace/internal/wrapping/context.py:481: error: Signature of "is_wrapped" incompatible with supertype "BaseWrappingContext"  [override]
+ ddtrace/internal/wrapping/context.py:481: note:      Superclass:
+ ddtrace/internal/wrapping/context.py:481: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:481: note:          def is_wrapped(cls, _f: FunctionType) -> bool
+ ddtrace/internal/wrapping/context.py:481: note:      Subclass:
+ ddtrace/internal/wrapping/context.py:481: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:481: note:          def is_wrapped(cls, f: FunctionType) -> bool
+ ddtrace/internal/wrapping/context.py:485: error: Signature of "extract" incompatible with supertype "BaseWrappingContext"  [override]
+ ddtrace/internal/wrapping/context.py:485: note:      Superclass:
+ ddtrace/internal/wrapping/context.py:485: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:485: note:          def extract(cls, _f: FunctionType) -> BaseWrappingContext
+ ddtrace/internal/wrapping/context.py:485: note:      Subclass:
+ ddtrace/internal/wrapping/context.py:485: note:          @classmethod
+ ddtrace/internal/wrapping/context.py:485: note:          def extract(cls, f: FunctionType) -> _UniversalWrappingContext
+ ddtrace/internal/remoteconfig/_connectors.py:25: error: Signature of "default" incompatible with supertype "JSONEncoder"  [override]
+ ddtrace/internal/remoteconfig/_connectors.py:25: note:      Superclass:
+ ddtrace/internal/remoteconfig/_connectors.py:25: note:          def default(self, o: Any) -> Any
+ ddtrace/internal/remoteconfig/_connectors.py:25: note:      Subclass:
+ ddtrace/internal/remoteconfig/_connectors.py:25: note:          def default(self, obj: Any) -> Any
+ ddtrace/internal/coverage/code.py:353: error: Signature of "after_import" incompatible with supertype "ModuleWatchdog"  [override]
+ ddtrace/internal/coverage/code.py:353: note:      Superclass:
+ ddtrace/internal/coverage/code.py:353: note:          def after_import(self, module: Module) -> None
+ ddtrace/internal/coverage/code.py:353: note:      Subclass:
+ ddtrace/internal/coverage/code.py:353: note:          def after_import(self, _module: Module) -> None
+ ddtrace/internal/coverage/code.py:353: error: Signature of "after_import" incompatible with supertype "BaseModuleWatchdog"  [override]
+ ddtrace/internal/coverage/code.py:353: note:      Superclass:
+ ddtrace/internal/coverage/code.py:353: note:          def after_import(self, module: Module) -> None
+ ddtrace/internal/coverage/code.py:353: note:      Subclass:
+ ddtrace/internal/coverage/code.py:353: note:          def after_import(self, _module: Module) -> None
+ ddtrace/_trace/processor/__init__.py:188: error: Signature of "on_span_start" incompatible with supertype "SpanProcessor"  [override]
+ ddtrace/_trace/processor/__init__.py:188: note:      Superclass:
+ ddtrace/_trace/processor/__init__.py:188: note:          def on_span_start(self, span: Span) -> None
+ ddtrace/_trace/processor/__init__.py:188: note:      Subclass:
+ ddtrace/_trace/processor/__init__.py:188: note:          def on_span_start(self, _: Span) -> None
+ ddtrace/appsec/_iast/_ast/visitor.py:420: error: Signature of "visit_Module" incompatible with supertype "NodeVisitor"  [override]
+ ddtrace/appsec/_iast/_ast/visitor.py:420: note:      Superclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:420: note:          def visit_Module(self, node: Module) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:420: note:      Subclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:420: note:          def visit_Module(self, module_node: Module) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:460: error: Signature of "visit_FunctionDef" incompatible with supertype "NodeVisitor"  [override]
+ ddtrace/appsec/_iast/_ast/visitor.py:460: note:      Superclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:460: note:          def visit_FunctionDef(self, node: FunctionDef) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:460: note:      Subclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:460: note:          def visit_FunctionDef(self, def_node: FunctionDef) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:500: error: Signature of "visit_Call" incompatible with supertype "NodeVisitor"  [override]
+ ddtrace/appsec/_iast/_ast/visitor.py:500: note:      Superclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:500: note:          def visit_Call(self, node: Call) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:500: note:      Subclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:500: note:          def visit_Call(self, call_node: Call) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:624: error: Signature of "visit_BinOp" incompatible with supertype "NodeVisitor"  [override]
+ ddtrace/appsec/_iast/_ast/visitor.py:624: note:      Superclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:624: note:          def visit_BinOp(self, node: BinOp) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:624: note:      Subclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:624: note:          def visit_BinOp(self, call_node: BinOp) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:640: error: Signature of "visit_AugAssign" incompatible with supertype "NodeVisitor"  [override]
+ ddtrace/appsec/_iast/_ast/visitor.py:640: note:      Superclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:640: note:          def visit_AugAssign(self, node: AugAssign) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:640: note:      Subclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:640: note:          def visit_AugAssign(self, augassign_node: AugAssign) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:685: error: Signature of "visit_FormattedValue" incompatible with supertype "NodeVisitor"  [override]
+ ddtrace/appsec/_iast/_ast/visitor.py:685: note:      Superclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:685: note:          def visit_FormattedValue(self, node: FormattedValue) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:685: note:      Subclass:
+ ddtrace/appsec/_iast/_ast/visitor.py:685: note:          def visit_FormattedValue(self, fmt_value_node: FormattedValue) -> Any
+ ddtrace/appsec/_iast/_ast/visitor.py:716: error: Signature of "visit_JoinedStr" incompatible with supertype "NodeVisitor"  [override]

... (truncated 1769 lines) ...```

@ilevkivskyi
Copy link
Member

Note that there is the same lenient behavior in protocols (originally motivated by a parity with this nominal subtyping behaviour), you may want to test that one as well.

@JukkaL
Copy link
Collaborator

JukkaL commented Dec 30, 2024

My current thinking is that we'd add a new error code for LSP violations caused by argument names only (a sub error code of override). It would be disabled by default, but we might enable it by default one day (likely not very soon). Maybe --strict should enable it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants