fix(core): Proper retry count in KazooRetry #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #748 +/- ##
==========================================
- Coverage 97.01% 96.67% -0.34%
==========================================
Files 27 27
Lines 3549 3553 +4
==========================================
- Hits 3443 3435 -8
- Misses 106 118 +12 ☔ View full report in Codecov by Sentry. |
ceache
requested review from
bbangert,
jeffwidman,
a-ungurianu and
StephenSorriaux
| @@ -133,10 +133,10 @@ def __call__(self, func, *args, **kwargs): | |||
| except ConnectionClosedError: | |||
| raise | |||
| except self.retry_exceptions: | |||
| self._attempts += 1 | |||
| # Note: max_tries == -1 means infinite tries. | |||
There was a problem hiding this comment.
Do you see a way to test this case?
There was a problem hiding this comment.
I am not sure what you mean: what 'case'?
Do you mean that it on catches the exception if it is in the self.retry_exceptions set?
There was a problem hiding this comment.
I was thinking of the note Note: max_tries == -1 means infinite tries.
Make sure the number of attempts matches the `max_retry` parameter. Add unit tests to that effect.
StephenSorriaux
approved these changes
Apr 6, 2024
jeffwidman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the number of attempts matches the
max_retryparameter. Add unit tests to that effect.Why is this needed?
So that users can precisely control the number of retries
Proposed Changes
max_tryso we don't end up callingmax_tries + 1times the function.Does this PR introduce any breaking change?
No, it shouldn't.