Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use tempfile.TemporaryDirectory #337

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

use tempfile.TemporaryDirectory #337

wants to merge 1 commit into from
+44 −151

Conversation

dimbleby
Copy link
Contributor

cf python-poetry/poetry#5522

but note that there's a testcase in this repository:

poetry-core/tests/utils/test_helpers.py

Line 90 in 8c75c1a

def test_utils_helpers_temporary_directory_readonly_file():
. So if the pipeline passes that should give us confidence that this is good,

@dimbleby dimbleby mentioned this pull request Apr 30, 2022
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@dimbleby
Copy link
Contributor Author

Looks like Windows and python3.7 are not happy with this, https://bugs.python.org/issue26660 presumably.

if and when we eventually get to do this, should probably remove the unit test case also - it wouldn't make much sense to have a unit test for tempfile function.

@neersighted
Copy link
Member

Re: implementing this now, one option is python-poetry/poetry#5522 (comment)

@dimbleby dimbleby force-pushed the temporary-directory branch from 4bedfd5 to e48e797 Compare August 16, 2022 16:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dimbleby dimbleby force-pushed the temporary-directory branch from ab2682a to 64d7c86 Compare March 18, 2023 19:25
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@dimbleby
Copy link
Contributor Author

dimbleby commented Mar 18, 2023 •
edited
Loading

rebased on #566 so that we no longer need to care about Windows python 3.7 bugs

@dimbleby dimbleby force-pushed the temporary-directory branch 2 times, most recently from 7ecf628 to 21caebb Compare March 18, 2023 19:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dimbleby dimbleby force-pushed the temporary-directory branch from 2919f80 to 1f96d36 Compare April 25, 2023 10:00
@dimbleby dimbleby force-pushed the temporary-directory branch 2 times, most recently from 6f33977 to c6e9cb6 Compare May 20, 2023 13:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dimbleby dimbleby force-pushed the temporary-directory branch from c6e9cb6 to 8e58a44 Compare October 28, 2023 16:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dimbleby dimbleby marked this pull request as draft October 28, 2023 16:06
@dimbleby dimbleby force-pushed the temporary-directory branch from 8e58a44 to 33307e9 Compare March 2, 2024 14:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimbleby @neersighted