In Image.Image.seek(), clear core image if mode or size has changed #8450
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about TiffImagePlugin? Can we call super().seek() there? |
homm
reviewed
Oct 9, 2024
| @@ -2633,10 +2633,16 @@ def seek(self, frame: int) -> None: | |||
| """ | |||
|
|
|||
| # overridden by file handlers | |||
| if frame != 0: | |||
There was a problem hiding this comment.
Does it make impossible to call super().seek() for plugins prior Pillow 11?
There was a problem hiding this comment.
...yes, an external plugin would fail calling super().seek() if the user had Pillow < 11.
I could add a dedicated new method instead of using super().seek(), but any way you look at the idea of this PR, it is new functionality.
No, because at the end of TiffImagePlugin's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8439
#8390 stopped
load_prepare()from recreating the core image instance if the mode or size had changed, as might happen at the end of aseek()operation. After that PR, this was no longer needed for any of our internal plugins.However, #8439 has pointed out that this would still be helpful for external plugins. Rather than reverting the change, this PR suggests that external plugins can call
super().seek()at the end of theirseek()methods. That will then clear the core image instance if the mode or size has changed, allowingload_prepare()to detect that a new core image is needed.The advantage of this over a simple revert is that if a user calls
seek()on an image, but notload(), then the core image instance is discarded.