Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify read_mo logic regarding catalog.charset #1148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Nov 9, 2024

Catalog.charset is set to utf-8 when no charset is provided (which is the case here) so the if check is redundant.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (f1c8633) to head (1e648b5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   91.31%   91.27%   -0.04%     
==========================================
  Files          27       27              
  Lines        4618     4621       +3     
==========================================
+ Hits         4217     4218       +1     
- Misses        401      403       +2     
Flag Coverage Δ
macos-12-3.10 90.04% <100.00%> (-0.04%) ⬇️
macos-12-3.11 89.98% <100.00%> (-0.04%) ⬇️
macos-12-3.12 90.19% <100.00%> (-0.04%) ⬇️
macos-12-3.13-dev 89.72% <100.00%> (-0.04%) ⬇️
macos-12-3.8 89.97% <100.00%> (-0.04%) ⬇️
macos-12-3.9 89.97% <100.00%> (-0.04%) ⬇️
macos-12-pypy3.10 90.04% <100.00%> (-0.04%) ⬇️
ubuntu-22.04-3.10 90.06% <100.00%> (-0.04%) ⬇️
ubuntu-22.04-3.11 90.00% <100.00%> (-0.04%) ⬇️
ubuntu-22.04-3.12 90.21% <100.00%> (-0.04%) ⬇️
ubuntu-22.04-3.13-dev 89.74% <100.00%> (-0.04%) ⬇️
ubuntu-22.04-3.8 89.99% <100.00%> (-0.04%) ⬇️
ubuntu-22.04-3.9 89.99% <100.00%> (-0.04%) ⬇️
ubuntu-22.04-pypy3.10 90.06% <100.00%> (-0.04%) ⬇️
windows-2022-3.10 90.18% <100.00%> (-0.04%) ⬇️
windows-2022-3.11 90.12% <100.00%> (-0.04%) ⬇️
windows-2022-3.12 90.33% <100.00%> (-0.04%) ⬇️
windows-2022-3.13-dev 89.86% <100.00%> (-0.04%) ⬇️
windows-2022-3.8 90.11% <100.00%> (-0.04%) ⬇️
windows-2022-3.9 90.11% <100.00%> (-0.04%) ⬇️
windows-2022-pypy3.10 90.18% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant