feat: add abandoned_time_limit to PublisherStalledCheck #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cctdaniel
force-pushed
the
stalled-check-offline
branch
from
91f3b69
to
1ce4960
Compare
cctdaniel
commented
May 22, 2024
| @@ -221,7 +221,7 @@ def error_message(self) -> dict: | |||
| "symbol": self.__state.symbol, | |||
| "publisher_price": f"{self.__state.price} ± {self.__state.confidence_interval}", | |||
| "aggregate_price": f"{self.__state.price_aggregate} ± {self.__state.confidence_interval_aggregate}", | |||
| "deviation": deviation, | |||
| "deviation": f"{deviation:.2f}%", | |||
There was a problem hiding this comment.
drive-by: format string here instead of event.py which is cleaner
ayazabbas
approved these changes
May 22, 2024
ali-bahjati
reviewed
May 22, 2024
sample.config.yaml
Outdated
| @@ -46,7 +46,8 @@ checks: | |||
| max_aggregate_distance: 6 | |||
| PublisherStalledCheck: | |||
| enable: true | |||
There was a problem hiding this comment.
Setting enable to false wouldn't work?
There was a problem hiding this comment.
well the reason for this is to test it for a couple of symbols first (since the less liquid ones are noisy), if we set it to false then all will be disabled
There was a problem hiding this comment.
Hmmm i think this is because if this be false then other checks should override enable and sat enable: true. But that's clear now.
ali-bahjati
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.