Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add llc modal #297

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add llc modal #297

wants to merge 14 commits into from

Conversation

0xfirefist
Copy link
Contributor

For when

  • user has a stake account
    • isLLCMember == true -> no modal popup
    • isLLCMember == false
      • modal pops up when wallets connect. if signed, there won't be a popup when depositing.
      • modal pops up when depositing or staking (via "locked" modal)
      • no modal will popup when withdrawing or unstaking"
  • user doesn't have a stake account
    • modal pops up when depositing

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 0:38am
staking-devnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 0:38am

guibescos
guibescos requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry had a lot of nitpicks, main thing though is functionally it doesn't work, I'll send you a video of what I'm observing

guibescos
guibescos reviewed Dec 12, 2023
View reviewed changes
staking/app/StakeConnection.ts Outdated
@@ -597,6 +597,15 @@ export class StakeConnection {
await this.provider.sendAndConfirm(transaction);
}

/**
* Join the DAO LLC for the give stake account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give -> given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guibescos guibescos guibescos requested changes

@cctdaniel cctdaniel Awaiting requested review from cctdaniel cctdaniel is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xfirefist @guibescos