Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache class: Fix crash on data race on Windows. #12579

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Cache class: Fix crash on data race on Windows. #12579

merged 2 commits into from
Jul 6, 2024

Commits on Jul 5, 2024

  1. Cache class: Fix crash on data race on Windows. 

    On Windows, the error gets mapped to a different
errno when a race happens, see
https://github.com/python/cpython/blob/cecd6012b0ed5dca3916ae341e705ae44172991d/PC/errmap.h#L107.
Therefore, we were observing crashes from that
code path, as the error wasn't being handled,
but bubbled up.
    @criemen
    criemen committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    685b2fe View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e1b684a View commit details
    Browse the repository at this point in the history