Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyupgrade #1036

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Use pyupgrade #1036

merged 6 commits into from
Jul 3, 2024

Conversation

kurtmckee
Copy link
Contributor

This PR introduces the following changes:

  • Immunized usage of io.open() so it doesn't get rewritten by pyupgrade
  • Ran upadup to update pre-commit hooks' additional_dependencies
  • Ran pre-commit run -a to fix the docs based on a much newer black version used by blacken-docs
  • Added pyupgrade as a pre-commit hook, with Python 3.7+ idioms enforced

Closes #1020

Describe the changes

The related issue or a description of the bug or feature that this PR addresses.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing
  • For documentation changes: The Read the Docs preview builds and looks as expected

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also merits an entry in the release notes (under the "infrastructure" heading).
Thanks for that, I didn't expect that you follow up so fast after my comment!

.pre-commit-config.yaml Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
pyfakefs/fake_file.py Show resolved Hide resolved
Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mrbean-bremen mrbean-bremen merged commit 9c19d6a into pytest-dev:main Jul 3, 2024
67 checks passed
@kurtmckee kurtmckee deleted the use-pyupgrade branch July 3, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.5.0: pyupgrade --py38-plus generated patch cause pytest fails
2 participants