Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back Letterbox transform #212

Merged
merged 9 commits into from
Jun 23, 2024
Merged

Put back Letterbox transform #212

merged 9 commits into from
Jun 23, 2024

Conversation

MateoLostanlen
Copy link
Member

After reading some disscutions on the ultralytics repo, I had removed the Letterbox preprocessing to gain in simplicity since it was considered unnecessary. I tested it on an image and obtained a similar result. After noticing some strange results this week, I measured the model's performance on an entire dataset using engine and got a much lower result. Using the Letterbox transformation, we get the same results as those obtained with the ultralytics library. Therefore, we need to add it again

Sorry for this error

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (4c7aebf) to head (ff0237d).

Files Patch % Lines
pyroengine/utils.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #212      +/-   ##
===========================================
- Coverage    92.38%   92.30%   -0.08%     
===========================================
  Files            6        6              
  Lines          486      507      +21     
===========================================
+ Hits           449      468      +19     
- Misses          37       39       +2     
Flag Coverage Δ
unittests 92.30% <94.59%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoLostanlen MateoLostanlen self-assigned this Jun 23, 2024
@MateoLostanlen MateoLostanlen added type: bug Something isn't working module: vision labels Jun 23, 2024
@MateoLostanlen MateoLostanlen requested a review from a team June 23, 2024 13:12
@MateoLostanlen MateoLostanlen merged commit 0a1ae7c into develop Jun 23, 2024
13 of 14 checks passed
@MateoLostanlen MateoLostanlen deleted the fix_onnx branch June 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: vision type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant