-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor engine v2 #206
Merged
Merged
Refactor engine v2 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateoLostanlen
added
type: enhancement
New feature or request
module: engine
ext: src
type: breaking change
module: sensors
module: core
labels
Jun 16, 2024
MateoLostanlen
force-pushed
the
refactor_engine_v2
branch
from
June 16, 2024 17:18
6f59b6e
to
0d4ebf6
Compare
RonanMorgan
reviewed
Jun 17, 2024
RonanMorgan
previously approved these changes
Jun 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #206 +/- ##
===========================================
+ Coverage 88.69% 92.38% +3.69%
===========================================
Files 6 6
Lines 398 486 +88
===========================================
+ Hits 353 449 +96
+ Misses 45 37 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MateoLostanlen
force-pushed
the
refactor_engine_v2
branch
from
June 17, 2024 10:45
66810f7
to
8dd7c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ext: src
module: core
module: engine
module: sensors
type: breaking change
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring for PTZ Camera Integration
Overview
This PR proposes a refactor of the code to prepare for the use of PTZ cameras. It includes two main features:
Changes
Details
Additional Changes
credentials.json
file with dummy values, and made minor adjustments to improve clarity and accuracy.Sorry for the big PR, but these changes were essential to ensure everything works together smoothly.