-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precommit hook #198
Add precommit hook #198
Conversation
…ording to the ressources' host
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #198 +/- ##
===========================================
- Coverage 87.92% 87.69% -0.24%
===========================================
Files 6 6
Lines 381 382 +1
===========================================
Hits 335 335
- Misses 46 47 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RonanMorgan, thnaks for your PR ! please can you add the setup-docker-compose.sh script to the script folder and generate a docker-compose.override.yml ignore by git that will be read automatically in order to avoid changing a file track by git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the update.
Please do not change stuff that have nothing to do with this PR you should not format engine.py here
@MateoLostanlen sorry at the beginning I thought that it would be very small (to add precommit hook) and there is already so much PR open so that I prefered move forward |
@RonanMorgan what do you mean you're not going to continue with this PR? |
@MateoLostanlen : I am gonna keep this PR for the static check part |
TODO : if we use the precommit hook, we should remove the linting part in the makefile and also clean up the workflows... |
Install precommit hook, the same configuration as in pyro-engine.