Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy #175

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Fix mypy #175

merged 5 commits into from
Oct 26, 2023

Conversation

MateoLostanlen
Copy link
Member

We add many mypy erros this pr fix them

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #175 (ed6303b) into develop (61a3c37) will decrease coverage by 0.18%.
The diff coverage is 94.73%.

❗ Current head ed6303b differs from pull request most recent head b3d750f. Consider uploading reports for the commit b3d750f to get more accurate results

@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
- Coverage    87.97%   87.80%   -0.18%     
===========================================
  Files            6        6              
  Lines          366      369       +3     
===========================================
+ Hits           322      324       +2     
- Misses          44       45       +1     
Flag Coverage Δ
unittests 87.80% <94.73%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pyroengine/core.py 55.00% <100.00%> (+1.15%) ⬆️
pyroengine/engine.py 89.62% <100.00%> (ø)
pyroengine/utils.py 95.55% <100.00%> (ø)
pyroengine/vision.py 98.03% <85.71%> (-1.97%) ⬇️

@MateoLostanlen MateoLostanlen merged commit 49a23fb into develop Oct 26, 2023
11 of 12 checks passed
@MateoLostanlen MateoLostanlen deleted the fix_mypy branch October 26, 2023 20:54
@MateoLostanlen MateoLostanlen self-assigned this Oct 26, 2023
@MateoLostanlen MateoLostanlen added the type: bug Something isn't working label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant