Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop saving random #163

Closed

Conversation

MateoLostanlen
Copy link
Member

Saving random images became useless, it was a good idea at the beginning to grow our dataset but we have a lot of data now so let’s focus on important ones. Moreover we are moving slowly to temporal prediction so having one image alone will be useless

@MateoLostanlen MateoLostanlen requested review from a team July 24, 2023 08:44
@ghost
Copy link

ghost commented Jul 24, 2023

Nice of you to open a PR 🙏
When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review

@fe51
Copy link
Member

fe51 commented Jul 24, 2023

Hi there, thanks for the PR,

Before diving into the review, some food for thought:

To a certain extent I'm okay if it doesn't improve our vision algos.

By any chance, should we keep this process but only over a given period for each site? Keep this functionality (perhaps by lowering the frequency?) but, for example, only for the first X months of a new site ? Would it be relevant ?

Specifically, with regard to the temporal detection argument, wouldn't we want to obtain a series of random frames useful for our datasets ? Hence, keeping the feature saving random img but improving it to save consecutive frames ?

@MateoLostanlen
Copy link
Member Author

Hi @fe51, thanks for your comments. Ok I understand your point of view, so what I propose is to pass an argument to make this save optional and add the fact of saving N consecutive frames

@fe51
Copy link
Member

fe51 commented Jul 24, 2023

Yes perfect !

If you want, you can split it 2 features (1. making it optionnal, 2. saving N consecutives)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants