fix order of parameters in predictive #2905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestion to extend the MCMC example to replicate the SVI 90% CI. |
eb8680
requested changes
Aug 3, 2021
There was a problem hiding this comment.
@TradDog thanks for the PR! Sorry we have been slow to review.
Can you rerun the notebook in a different environment such that all the new error/debugging messages in your latest commit are scrubbed and remove the new cells in the HMC section with regression line plots copied from part 1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix predictive parameters. Please review. I am a perfect beginner in pyro and ppl in general.