Added cookie method, modified constructor so that it takes arguments now and handling custom driver object if passed as an argument #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts while object creation and custom driver object passing to the constructor have been added, fixed mistake in logging for open method while error. Fixed flake and pycode errors in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cookie method, modified constructor so that it takes arguments now and handling custom driver object if passed as an argument while object creation. fixed typo mistake in logging for open method while error. Fixed flake and pycode errors in this file
Description
This feature will now will help us to add cookie to session.
Passing custom arguments or keyword arguments while object creation. Earlier it was not possible since super class (Unittest.TestCase) constructor is not accepting args or kwargs but from browseractions constructor we are passing to it. Thereby it was causing issue while creating object.
Fixed a typo in logging instead of error there it was info.